From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9C4C468BD for ; Sat, 8 Jun 2019 19:41:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B22214AE for ; Sat, 8 Jun 2019 19:41:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r1VbWNin" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B22214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZhDF-0000XQ-2M for qemu-devel@archiver.kernel.org; Sat, 08 Jun 2019 15:41:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37943) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZh2H-0007kh-5p for qemu-devel@nongnu.org; Sat, 08 Jun 2019 15:29:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZh2G-0007xm-7m for qemu-devel@nongnu.org; Sat, 08 Jun 2019 15:29:53 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:46809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZh2G-0007xQ-3K for qemu-devel@nongnu.org; Sat, 08 Jun 2019 15:29:52 -0400 Received: by mail-oi1-x243.google.com with SMTP id 203so3686803oid.13 for ; Sat, 08 Jun 2019 12:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YZ4oxGbsUfYDMglYHvCwSjOkhVYTctKCxCwRbC/jYQM=; b=r1VbWNinMYx5Ook6KKSE602bJo4Euiccf5VHCuq0t3cpfPUGg3YzcqlIij/blsywoz uboEtyU2sZ42E5w9c/7UIVYgGx/EGKMQUGxM+Mo3d/6Zd66Hi5gopXDz+QK4VvzDLeYk GBfutXkNXgLPyqbqM57n6uPoOOe5FtARXqdKVNdtZi/WK2hWmvS0IyGqkq074DOOOXwq 9bvkb9DwfcIK7ktqu8o2uC5OxVJTuVInWSq00RSiEPOw5QsCIvs/gcoJbf2Pad2Ryhs8 yasuFmDLVZPjWQCUb+cV3bY1yL0WsC6Cc6okre75KkwWy7iRdoC6qf7TIecrX1gnCsJG iJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YZ4oxGbsUfYDMglYHvCwSjOkhVYTctKCxCwRbC/jYQM=; b=CvFoxSmGGqbDkYnWInyMuewnBoWmSHHKqw049uqtFOhIt5BZEkDxP5dMFiJ6yd5aVw Jboc06uW9LoSIv2yntVGua0Zs68KRtsx01C3Chnp1D4+Y9bnCjmIm4gBJXJjg2oIlxQN ZkUbDnH21GkFnsbvp+WyB/pSQCDIDCcAjZzUinz1YUbKyOrg8ALk/+Vdd3AseDmgs3J6 nu640nQaZ0kuQHFRARf0iRBE20yoA8fcn/PGKxmysxVlEW02ENMq4oSKrnp2GcaTERCb JtwUZqs2GGqVIXWUkVblrCCDFk+mpuqLzZv6sXeNR3irF6cvXTvDbdU2rgryqfTQqmzl Ep4w== X-Gm-Message-State: APjAAAUxESKpo8e7Jzb6zRVsDshi5sd7o1mO9ywPOs3GEH1/J+zaGO+K tfL7GX63fpgGsp/8VTt3Bs5BdffFPT0mXQ== X-Google-Smtp-Source: APXvYqw/HrWS03+bi6BAVSzpwduq1H7DEVWP7Glo/YpjosSQaOmRCyBvA3Rm21HJ6KIbZf0saC/9Hw== X-Received: by 2002:aca:3011:: with SMTP id w17mr200599oiw.150.1560022191161; Sat, 08 Jun 2019 12:29:51 -0700 (PDT) Received: from [10.219.49.199] ([187.217.230.84]) by smtp.gmail.com with ESMTPSA id m17sm2070530otl.38.2019.06.08.12.29.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jun 2019 12:29:50 -0700 (PDT) To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20190606174609.20487-1-peter.maydell@linaro.org> <20190606174609.20487-34-peter.maydell@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <49bc9d4a-4d59-f8d1-ab6c-5873123330d1@linaro.org> Date: Sat, 8 Jun 2019 14:02:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190606174609.20487-34-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 Subject: Re: [Qemu-devel] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/6/19 12:46 PM, Peter Maydell wrote: > + vd = tcg_temp_new_i32(); > + vm = tcg_temp_new_i32(); > + > + neon_load_reg32(vd, a->vd); > + if (a->z) { > + tcg_gen_movi_i32(vm, 0); > + } else { > + neon_load_reg32(vm, a->vm); > + } > + > + if (a->e) { > + gen_helper_vfp_cmpes(vd, vm, cpu_env); > + } else { > + gen_helper_vfp_cmps(vd, vm, cpu_env); > + } > + return true; Missing the temp frees, again in the dp version. Otherwise, Reviewed-by: Richard Henderson r~