From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45DFFC433EF for ; Mon, 2 May 2022 22:10:21 +0000 (UTC) Received: from localhost ([::1]:55472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nleFI-00077T-AP for qemu-devel@archiver.kernel.org; Mon, 02 May 2022 18:10:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nle6P-0001O7-Ds for qemu-devel@nongnu.org; Mon, 02 May 2022 18:01:09 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:46667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nle6M-000626-O6 for qemu-devel@nongnu.org; Mon, 02 May 2022 18:01:09 -0400 Received: by mail-pf1-x42d.google.com with SMTP id j6so13293140pfe.13 for ; Mon, 02 May 2022 15:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uq8MAjc9XgZJXsddHS6tI+FIfn4GHV263dEfmtyxv8w=; b=DC8vvFGPY0aNn755NRHaWQF2uvYMM4yVEw8rMnK4/IpnWz7wPBdJpw5uMDVFjWmpNq P7SBtR6tKsBPaiReYDuus18p6ckbhO3fZxNMgAc123QjM8vDj8MLvaK3IiXfVv7d5YsS AMPO/6dDynO7Btpc7RAM99V7d7c/LOWbupjCM+8Jt940MXjYPiqkX/20BMSA/T51BqyD hyiwnVwoqB8v32Idf3iNAYaH/Afc0egGGEUSgPCVXLlbC3cBYqhLxBb3Ds8DoJT6PgMg /V0Xxw+PplK/YOQn6dFYj0469pyYRhIc6n9D3mR27ovYvJowlFPg8M/rRECS0z1+9D45 4F4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uq8MAjc9XgZJXsddHS6tI+FIfn4GHV263dEfmtyxv8w=; b=F3hsbrRhY3zsJW9o6X8dIPMiIYWfVwiWjlhjmjJvmNb0EYudIoKpgaYDe/GNu7K/cM T0ntxEBIyX9J5F3uGjZ2SFAYn5IkJaTHuyLOhVqdam3DDtmszOytuQsI61pZHnKnogG4 HD6KUpU57TMOY7fEb8RgAQ+9CdfwPirwuyimHHD9L7i1ZsJ1aXPXe3X6VRVFFJmbeXU2 dsBi7K/RSYaRXh8ilEvkhjMu+askh26Xbe7oAkCnb72d0ahYT23Z1lAijfnHeNzXjsva GiuD4ZieGbxaEk1HsYf58aRJj+lqnqjlEWrkiGiHCgYsTpQemhgcsFv2qf+jBn4/s0Fx wscw== X-Gm-Message-State: AOAM5339p+x/FDQfx1npSI/aSwJr6aIReJveYm9Z/iOXV48GjSaRqNL4 BC9XZWHK8/v+oobhoAQ+qftG3w== X-Google-Smtp-Source: ABdhPJxHTmPM14NvLd9UWk50PAs9LRItBqlWRRVXW05ARP1ohoo4yvZGirmBRYl/o26KdOD0JoPDCg== X-Received: by 2002:a63:8543:0:b0:3ab:5afb:200c with SMTP id u64-20020a638543000000b003ab5afb200cmr11191186pgd.402.1651528863306; Mon, 02 May 2022 15:01:03 -0700 (PDT) Received: from [192.168.1.6] ([71.212.142.129]) by smtp.gmail.com with ESMTPSA id f9-20020a170902ce8900b0015e8d4eb1c6sm5125761plg.16.2022.05.02.15.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 15:01:02 -0700 (PDT) Message-ID: <49c186c4-af06-0bdf-26ad-200564c4d191@linaro.org> Date: Mon, 2 May 2022 15:01:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 18/21] target/ppc: Remove msr_ts macro Content-Language: en-US To: =?UTF-8?Q?V=c3=adctor_Colombo?= , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au, groug@kaod.org, balaton@eik.bme.hu References: <20220502143934.71908-1-victor.colombo@eldorado.org.br> <20220502143934.71908-19-victor.colombo@eldorado.org.br> From: Richard Henderson In-Reply-To: <20220502143934.71908-19-victor.colombo@eldorado.org.br> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/2/22 07:39, Víctor Colombo wrote: > msr_ts macro hides the usage of env->msr, which is a bad > behavior. Substitute it with FIELD_EX64 calls that explicitly use > env->msr as a parameter. > > Suggested-by: Richard Henderson > Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~