From: Max Reitz <mreitz@redhat.com>
To: "sochin.jiang" <sochin.jiang@huawei.com>,
jcody@redhat.com, kwolf@redhat.com
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
eric.fangyi@huawei.com, subo7@huawei.com, xieyingtai@huawei.com,
lina.lulina@huawei.com, zhangshuai13@huawei.com,
lizhengui@huawei.com
Subject: Re: [Qemu-devel] [PATCH] fix: avoid an infinite loop or a dangling pointer problem in img_commit
Date: Fri, 16 Jun 2017 15:27:22 +0200 [thread overview]
Message-ID: <49c65c67-5dcc-5822-c2f9-e1c3ff0181de@redhat.com> (raw)
In-Reply-To: <1497509253-28941-1-git-send-email-sochin.jiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On 2017-06-15 08:47, sochin.jiang wrote:
> From: "sochin.jiang" <sochin.jiang@huawei.com>
>
> img_commit could fall into an infinite loop calling run_block_job() if
> its blockjob fails on any I/O error, fix this already known problem.
>
> Signed-off-by: sochin.jiang <sochin.jiang@huawei.com>
> ---
> blockjob.c | 4 ++--
> include/block/blockjob.h | 18 ++++++++++++++++++
> qemu-img.c | 20 +++++++++++++-------
> 3 files changed, 33 insertions(+), 9 deletions(-)
Thanks! I've applied the patch to my block branch:
https://github.com/XanClic/qemu/commits/block
PS: In the future, please change the subject prefix to "PATCH v2" (etc.)
for updated versions of a patch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
next prev parent reply other threads:[~2017-06-16 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 6:47 [Qemu-devel] [PATCH] fix: avoid an infinite loop or a dangling pointer problem in img_commit sochin.jiang
2017-06-16 13:27 ` Max Reitz [this message]
2017-06-17 1:22 ` sochin.jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49c65c67-5dcc-5822-c2f9-e1c3ff0181de@redhat.com \
--to=mreitz@redhat.com \
--cc=eric.fangyi@huawei.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lina.lulina@huawei.com \
--cc=lizhengui@huawei.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sochin.jiang@huawei.com \
--cc=subo7@huawei.com \
--cc=xieyingtai@huawei.com \
--cc=zhangshuai13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).