From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B767EC433E0 for ; Tue, 4 Aug 2020 16:35:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CFC322B40 for ; Tue, 4 Aug 2020 16:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hg6D0O6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CFC322B40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2zuD-0001VN-8H for qemu-devel@archiver.kernel.org; Tue, 04 Aug 2020 12:35:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2ztS-00014G-RR for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:34:26 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:59101 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k2ztR-0001du-7E for qemu-devel@nongnu.org; Tue, 04 Aug 2020 12:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596558864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9BCTpmiIz4/MpMMiQjmm8+jD9roxn3YXfPCWsE9HPYo=; b=Hg6D0O6HgpmKbcsdzYgbTC8TGEusL+4jD8NYyHycPi1S1o1PA5UYL73iImxXFy5/yHdb7D MKUgP+0An0//V0TyyplJ/riJkRz6iscUcD9lpyWmE6F5A1u/+3fDwnph0dW96nt660wRi2 k4XytNgwg+Twfhyh9SYcIoRQoK8qE3o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-zCNogHjYPaqhGRTc2tOdgw-1; Tue, 04 Aug 2020 12:34:14 -0400 X-MC-Unique: zCNogHjYPaqhGRTc2tOdgw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A7E71902EA1; Tue, 4 Aug 2020 16:34:12 +0000 (UTC) Received: from [10.3.113.202] (ovpn-113-202.phx2.redhat.com [10.3.113.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F165619C71; Tue, 4 Aug 2020 16:34:11 +0000 (UTC) Subject: Re: [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function To: Chuan Zheng , quintela@redhat.com, dgilbert@redhat.com References: <1595646669-109310-1-git-send-email-zhengchuan@huawei.com> <1595646669-109310-9-git-send-email-zhengchuan@huawei.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <49c8243d-3f9d-9420-c921-590cd80e8888@redhat.com> Date: Tue, 4 Aug 2020 11:34:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1595646669-109310-9-git-send-email-zhengchuan@huawei.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/04 01:28:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com, qemu-devel@nongnu.org, alex.chen@huawei.com, ann.zhuangyanying@huawei.com, fangying1@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/24/20 10:11 PM, Chuan Zheng wrote: > From: Zheng Chuan > > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called > by libvirt api. > > Signed-off-by: Zheng Chuan > Signed-off-by: YanYing Zhang > +## > +{ 'command': 'get_dirty_rate', 'returns': 'int64' } > diff --git a/qapi/pragma.json b/qapi/pragma.json > index cffae27..ecd294b 100644 > --- a/qapi/pragma.json > +++ b/qapi/pragma.json > @@ -10,7 +10,8 @@ > 'query-migrate-cache-size', > 'query-tpm-models', > 'query-tpm-types', > - 'ringbuf-read' ], > + 'ringbuf-read', > + 'get_dirty_rate' ], Nack. You should not have to change the whitelist; this is evidence that your command is returning the wrong type. Instead, you should be using: { 'command': 'get-dirty-rate', 'returns': { 'rate': 'int64' } } and populating a struct, so that if we ever want to return more than just a single rate, we can extend the command in-place by adding to the struct. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org