From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAC60C77B62 for ; Mon, 3 Apr 2023 12:52:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjJeq-00078f-5u; Mon, 03 Apr 2023 08:51:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjEgQ-0000Ls-8o for qemu-devel@nongnu.org; Mon, 03 Apr 2023 03:32:54 -0400 Received: from hq-ms.auriga.com ([82.97.202.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjEgN-0004VN-RW for qemu-devel@nongnu.org; Mon, 03 Apr 2023 03:32:54 -0400 Received: from HQ-MS1.office.auriga.msk (82.97.202.32) by hq-ms1.office.auriga.msk (82.97.202.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Mon, 3 Apr 2023 10:21:34 +0300 Received: from HQ-MS1.office.auriga.msk ([fe80::4260:7fa4:9d90:6a4]) by hq-ms1.office.auriga.msk ([fe80::4260:7fa4:9d90:6a4%4]) with mapi id 15.02.1118.020; Mon, 3 Apr 2023 10:21:34 +0300 From: "Kambalin, Sergey" To: =?gb2312?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkqKY=?= , "Sergey Kambalin" , "qemu-devel@nongnu.org" Subject: Re: [PATCH] Make bootable RPi4B model Thread-Topic: [PATCH] Make bootable RPi4B model Thread-Index: AQHZZYOjYBGb8AwaJkq25tl8aVt1VK8Y9AeAgAA3h5I= Date: Mon, 3 Apr 2023 07:21:33 +0000 Message-ID: <49d14fcd4ece4b5bb5f8671b43d8c2af@auriga.com> References: <20230402165306.137092-1-sergey.kambalin@auriga.com>, In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.191.220.81] x-tm-as-product-ver: SMEX-14.0.0.1158-9.0.1002-27542.001 x-tm-as-result: No-10--14.659200-8.000000 x-tmase-matchedrid: IWY1H69iwzqJVA+ukO+5MWg4D2QV/2zL6r3HCixfuKcc4ri4RJV/1W/R DAZTdSI3QnEYvg6//klFmXhQ6rgRVOyDy8V8lTWUzH6d90mb4+Ih6cl1707zKlZxVB3B2qbP6Xk ezPna397QLE3MitZAfl9/IWsrV5Ek1LFdtmiebE5itzfafzhYerzutTz14s8peZ45ULYLKJNNsi /bk0au/dXoB9VhhQjLkal2kc7jh2YQcafPsw1WnC+PrAd8gbHJb0NcOFSwefIhm837eIt7zYtH2 SdBWxvyRKy3EMcSFoDJspWbiyjo+lcXzsaYdfq0rmLeMrcoM6iZmLDnd2pI3+PsX9qV3arkaV+s 9jXgu68DCvV3UwP6eBY8qLUhOhRKsEBAuoaUqK+If3m0sUfx5+io2PgrXLs41YzbHoRn9L2R5xt feKAptiER4oyikLD9/76CM4Z/MGbQ3sOMB3Fk1OLzNWBegCW2Fw5hfb1M/f6wxhlzj2zwm6KVxQ goNH15XRw2IdQKZOGaYJyl6AkboUGyQ7v//E9hlExlQIQeRG0= x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No x-tmase-result: 10--14.659200-8.000000 x-tmase-version: SMEX-14.0.0.1158-9.0.1002-27542.001 x-tm-snts-smtp: 3956783C8207A1CAB4928AC2C4DA81283C66EB7EC762B33A84B7D5E261DDC2882000:8 Content-Type: multipart/alternative; boundary="_000_49d14fcd4ece4b5bb5f8671b43d8c2afaurigacom_" MIME-Version: 1.0 Received-SPF: pass client-ip=82.97.202.32; envelope-from=sergey.kambalin@auriga.com; helo=hq-ms.auriga.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 03 Apr 2023 08:51:34 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --_000_49d14fcd4ece4b5bb5f8671b43d8c2afaurigacom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SGkgUGhpbCENCg0KDQpJJ3ZlIHB1dCB1bml0IHRlc3RzIHRvIGEgc2VwYXJhdGUgcGF0Y2ggaW4g b3JkZXIgdG8gbm90IG92ZXJ3aGVsbSB5b3Ugd2l0aCBjb2RlLg0KDQpJdCBpcyBhbHJlYWR5IGEg aHVnZSBwaWVjZSwgYW5kIEkgYWdyZWUgdGhhdCAgMzAwMCsgbGluZXMgYXJlIGEgc29ydCBvZiBh IGNoYWxsZW5nZSB0byBhIHJldmlld2VyLg0KDQpPSywgSSdsbCB0cnkgdG8gc3BsaXQgaXQgaW50 byBhIHNldmVyYWwgcGF0Y2hlcyAtIGNvcmUgZnVuY3Rpb25hbGl0eSArIGEgc2luZ2xlIHBhdGNo IGZvciBlYWNoIGRldmljZSAoZ3BpbywgdHJuZywgdGhlcm1hbCBzZW5zb3JzKQ0KDQoNCkJSLA0K DQpTZXJnZXkNCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCqewp+Q6IFBoaWxp cHBlIE1hdGhpZXUtRGF1ZKimIDxwaGlsbWRAbGluYXJvLm9yZz4NCqewp+Sn4afip9Gn06fdp9an 36fgOiAzIKfRp+Gn4qfWp92n8SAyMDIzIKfULiA5OjUxOjExDQqnrKfgp96n5TogU2VyZ2V5IEth bWJhbGluOyBxZW11LWRldmVsQG5vbmdudS5vcmcNCqesp+Cn4afap/E6IEthbWJhbGluLCBTZXJn ZXkNCqe0p9an3qfROiBSZTogW1BBVENIXSBNYWtlIGJvb3RhYmxlIFJQaTRCIG1vZGVsDQoNCkhp IFNlcmdleSwNCg0KT24gMi80LzIzIDE4OjUzLCBTZXJnZXkgS2FtYmFsaW4gd3JvdGU6DQo+IFNp Z25lZC1vZmYtYnk6IFNlcmdleSBLYW1iYWxpbiA8c2VyZ2V5LmthbWJhbGluQGF1cmlnYS5jb20+ DQo+IC0tLQ0KPiAgIGNvbmZpZ3MvZGV2aWNlcy9hYXJjaDY0LXNvZnRtbXUvZGVmYXVsdC5tYWsg fCAgIDEgKw0KPiAgIGh3L2FybS9LY29uZmlnICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDcgKw0KPiAgIGh3L2FybS9iY20yODM1X3BlcmlwaGVyYWxzLmMgICAgICAgICAgICAgICAg fCAyMTggKysrKysrLS0tLQ0KPiAgIGh3L2FybS9iY20yODM2LmMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAxMjkgKysrLS0tDQo+ICAgaHcvYXJtL2JjbTI4MzguYyAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8IDI5NCArKysrKysrKysrKysrKw0KPiAgIGh3L2FybS9iY20yODM4X3Bj aWUuYyAgICAgICAgICAgICAgICAgICAgICAgfCAzMDAgKysrKysrKysrKysrKysNCj4gICBody9h cm0vYmNtMjgzOF9wZXJpcGhlcmFscy5jICAgICAgICAgICAgICAgIHwgMjYyICsrKysrKysrKysr Kw0KPiAgIGh3L2FybS9tZXNvbi5idWlsZCAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDYg Kw0KPiAgIGh3L2FybS9yYXNwaS5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMjgg KysrLS0tDQo+ICAgaHcvYXJtL3Jhc3BpNGIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 IDIzMiArKysrKysrKysrKw0KPiAgIGh3L2FybS90cmFjZS1ldmVudHMgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDYgKw0KPiAgIGh3L2dwaW8vYmNtMjgzOF9ncGlvLmMgICAgICAgICAgICAg ICAgICAgICAgfCAzOTUgKysrKysrKysrKysrKysrKysrDQo+ICAgaHcvZ3Bpby9tZXNvbi5idWls ZCAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMSArDQo+ICAgaHcvbWlzYy9iY20yODM1X3By b3BlcnR5LmMgICAgICAgICAgICAgICAgICB8IDMxOCArKysrKysrKysrKystLS0NCj4gICBody9t aXNjL2JjbTI4Mzhfcm5nMjAwLmMgICAgICAgICAgICAgICAgICAgIHwgNDIxICsrKysrKysrKysr KysrKysrKysrDQo+ICAgaHcvbWlzYy9iY20yODM4X3RoZXJtYWwuYyAgICAgICAgICAgICAgICAg ICB8ICA5NyArKysrKw0KPiAgIGh3L21pc2MvbWVzb24uYnVpbGQgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDQgKw0KPiAgIGh3L21pc2MvdHJhY2UtZXZlbnRzICAgICAgICAgICAgICAgICAg ICAgICAgfCAgMTAgKw0KPiAgIGluY2x1ZGUvaHcvYXJtL2JjbTI4MzVfcGVyaXBoZXJhbHMuaCAg ICAgICAgfCAgMjkgKy0NCj4gICBpbmNsdWRlL2h3L2FybS9iY20yODM2LmggICAgICAgICAgICAg ICAgICAgIHwgIDMwICstDQo+ICAgaW5jbHVkZS9ody9hcm0vYmNtMjgzOC5oICAgICAgICAgICAg ICAgICAgICB8ICAyNiArKw0KPiAgIGluY2x1ZGUvaHcvYXJtL2JjbTI4MzhfcGNpZS5oICAgICAg ICAgICAgICAgfCAgNjcgKysrKw0KPiAgIGluY2x1ZGUvaHcvYXJtL2JjbTI4MzhfcGVyaXBoZXJh bHMuaCAgICAgICAgfCAgNTYgKysrDQo+ICAgaW5jbHVkZS9ody9hcm0vcmFzcGk0Yl9wbGF0Zm9y bS5oICAgICAgICAgICB8ICA1NCArKysNCj4gICBpbmNsdWRlL2h3L2FybS9yYXNwaV9wbGF0Zm9y bS5oICAgICAgICAgICAgIHwgIDM0ICsrDQo+ICAgaW5jbHVkZS9ody9kaXNwbGF5L2JjbTI4MzVf ZmIuaCAgICAgICAgICAgICB8ICAgMiArDQo+ICAgaW5jbHVkZS9ody9ncGlvL2JjbTI4MzhfZ3Bp by5oICAgICAgICAgICAgICB8ICA0NSArKysNCj4gICBpbmNsdWRlL2h3L21pc2MvYmNtMjgzOF9y bmcyMDAuaCAgICAgICAgICAgIHwgIDc3ICsrKysNCj4gICBpbmNsdWRlL2h3L21pc2MvYmNtMjgz OF90aGVybWFsLmggICAgICAgICAgIHwgIDI0ICsrDQo+ICAgaW5jbHVkZS9ody9taXNjL3Jhc3Bi ZXJyeXBpLWZ3LWRlZnMuaCAgICAgICB8IDE2OSArKysrKysrKw0KPiAgIDMwIGZpbGVzIGNoYW5n ZWQsIDMxNzUgaW5zZXJ0aW9ucygrKSwgMjY3IGRlbGV0aW9ucygtKQ0KDQpUaGUgcGF0Y2ggc3Vi amVjdCBzb3VuZHMgcHJvbWlzaW5nISBIb3dldmVyIDMxNzUgbGluZXMgb2YNCmNvZGUgdG8gcmV2 aWV3IGlzIGEgYml0IGhhcmRjb3JlLi4uIENvdWxkIHlvdSBzcGxpdCB5b3VyDQpwYXRjaCBwZXIg ZGV2aWNlIChhdCBsZWFzdCk/DQoNCklkZWFsbHkgb25lIHBhdGNoIHNob3VsZCBjb250YWluIGEg c2luZ2xlIGxvZ2ljYWwgY2hhbmdlLg0KDQpBbHNvLCBjYW4geW91IHByb3ZpZGUgaG93IHlvdSB0 ZXN0ZWQgeW91ciBwYXRjaD8NCg0KVGhhbmtzLA0KDQpQaGlsLg0K --_000_49d14fcd4ece4b5bb5f8671b43d8c2afaurigacom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Hi Phil!


I've put unit tests to a separate patch in order to not overwhelm you wi= th code.

It is already a huge piece, and I agree that  3000+ lines are a sort of a challenge to a reviewer.

OK, I'll try to split it into a several patches - core functionality = 3; a single patch for each device (gpio, trng, thermal sensors)


BR,

Sergey

=A7=B0=A7=E4: Philippe Ma= thieu-Daud=A8=A6 <philmd@linaro.org>
=A7=B0=A7=E4=A7=E1=A7=E2=A7=D1=A7=D3=A7=DD=A7=D6=A7=DF=A7=E0: 3 =A7= =D1=A7=E1=A7=E2=A7=D6=A7=DD=A7=F1 2023 =A7=D4. 9:51:11
=A7=AC=A7=E0=A7=DE=A7=E5: Sergey Kambalin; qemu-devel@nongnu.org
=A7=AC=A7=E0=A7=E1=A7=DA=A7=F1: Kambalin, Sergey
=A7=B4=A7=D6=A7=DE=A7=D1: Re: [PATCH] Make bootable RPi4B model
 
Hi Sergey,

On 2/4/23 18:53, Sergey Kambalin wrote:
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>   configs/devices/aarch64-softmmu/default.mak |   = 1 +
>   hw/arm/Kconfig       &n= bsp;            = ;          |   7 = 3;
>   hw/arm/bcm2835_peripherals.c     =            | 218 += 3;++++----
>   hw/arm/bcm2836.c       =             &nb= sp;        | 129 +++---
>   hw/arm/bcm2838.c       =             &nb= sp;        | 294 ++++= 3;+++++++++
>   hw/arm/bcm2838_pcie.c      &= nbsp;           &nbs= p;    | 300 +++++++++= 3;++++
>   hw/arm/bcm2838_peripherals.c     =            | 262 += 3;++++++++++
>   hw/arm/meson.build      &nbs= p;            &= nbsp;      |   6 +
>   hw/arm/raspi.c       &n= bsp;            = ;          | 128 ++= 3;---
>   hw/arm/raspi4b.c       =             &nb= sp;        | 232 ++++= 3;++++++
>   hw/arm/trace-events      &nb= sp;            =       |   6 +
>   hw/gpio/bcm2838_gpio.c      =             &nb= sp;   | 395 ++++++++++= 3;+++++++
>   hw/gpio/meson.build      &nb= sp;            =       |   1 +
>   hw/misc/bcm2835_property.c     &n= bsp;            | 31= 8 ++++++++++++---
>   hw/misc/bcm2838_rng200.c     &nbs= p;            &= nbsp; | 421 ++++++++++++= 3;+++++++
>   hw/misc/bcm2838_thermal.c     &nb= sp;            = |  97 +++++
>   hw/misc/meson.build      &nb= sp;            =       |   4 +
>   hw/misc/trace-events      &n= bsp;            = ;     |  10 +
>   include/hw/arm/bcm2835_peripherals.h   &nbs= p;    |  29 +-
>   include/hw/arm/bcm2836.h     &nbs= p;            &= nbsp; |  30 +-
>   include/hw/arm/bcm2838.h     &nbs= p;            &= nbsp; |  26 ++
>   include/hw/arm/bcm2838_pcie.h     = ;          |  67 += 3;++
>   include/hw/arm/bcm2838_peripherals.h   &nbs= p;    |  56 +++
>   include/hw/arm/raspi4b_platform.h    &= nbsp;      |  54 +++
>   include/hw/arm/raspi_platform.h    &nb= sp;        |  34 ++
>   include/hw/display/bcm2835_fb.h    &nb= sp;        |   2 +
>   include/hw/gpio/bcm2838_gpio.h    &nbs= p;         |  45 ++= 3;
>   include/hw/misc/bcm2838_rng200.h    &n= bsp;       |  77 ++++ >   include/hw/misc/bcm2838_thermal.h    &= nbsp;      |  24 ++
>   include/hw/misc/raspberrypi-fw-defs.h   &nb= sp;   | 169 ++++++++
>   30 files changed, 3175 insertions(+), 267 deletions(-)=

The patch subject sounds promising! However 3175 lines of
code to review is a bit hardcore... Could you split your
patch per device (at least)?

Ideally one patch should contain a single logical change.

Also, can you provide how you tested your patch?

Thanks,

Phil.
 --_000_49d14fcd4ece4b5bb5f8671b43d8c2afaurigacom_--