From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9BBC32750 for ; Tue, 13 Aug 2019 19:07:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 167C020842 for ; Tue, 13 Aug 2019 19:07:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 167C020842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxc98-00059b-Eu for qemu-devel@archiver.kernel.org; Tue, 13 Aug 2019 15:07:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49189) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxc7r-00040x-FK for qemu-devel@nongnu.org; Tue, 13 Aug 2019 15:06:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxc7q-0005ws-9p for qemu-devel@nongnu.org; Tue, 13 Aug 2019 15:06:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59298) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxc7m-0005sq-Bn; Tue, 13 Aug 2019 15:06:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD26836899; Tue, 13 Aug 2019 19:06:24 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58F6737DE; Tue, 13 Aug 2019 19:06:20 +0000 (UTC) To: Sam Eiderman , kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, seabios@seabios.org, kraxel@redhat.com, kevin@koconnor.net References: <20190626123948.10199-1-shmuel.eiderman@oracle.com> <20190626123948.10199-5-shmuel.eiderman@oracle.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <49d3db3b-5a66-c87d-8d78-157bd0201731@redhat.com> Date: Tue, 13 Aug 2019 21:06:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190626123948.10199-5-shmuel.eiderman@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TbT4fuIm9LFAPXCRFLYTOv7SEg52i1AT5" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 13 Aug 2019 19:06:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liran.alon@oracle.com, karl.heubaum@oracle.com, arbel.moshe@oracle.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TbT4fuIm9LFAPXCRFLYTOv7SEg52i1AT5 Content-Type: multipart/mixed; boundary="kLucQT5g4pN9xz331Famfw3jVVHzsLaBf"; protected-headers="v1" From: Max Reitz To: Sam Eiderman , kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, seabios@seabios.org, kraxel@redhat.com, kevin@koconnor.net Cc: karl.heubaum@oracle.com, liran.alon@oracle.com, arbel.moshe@oracle.com Message-ID: <49d3db3b-5a66-c87d-8d78-157bd0201731@redhat.com> Subject: Re: [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd References: <20190626123948.10199-1-shmuel.eiderman@oracle.com> <20190626123948.10199-5-shmuel.eiderman@oracle.com> In-Reply-To: <20190626123948.10199-5-shmuel.eiderman@oracle.com> --kLucQT5g4pN9xz331Famfw3jVVHzsLaBf Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 26.06.19 14:39, Sam Eiderman wrote: > We will need to add LCHS removal logic to scsi-hd's unrealize() in the > next commit. >=20 > Reviewed-by: Karl Heubaum > Reviewed-by: Arbel Moshe > Signed-off-by: Sam Eiderman > --- > hw/scsi/scsi-bus.c | 15 +++++++++++++++ > include/hw/scsi/scsi.h | 1 + > 2 files changed, 16 insertions(+) >=20 > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index c480553083..f6fe497a1a 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c [...] > @@ -213,11 +221,18 @@ static void scsi_qdev_realize(DeviceState *qdev, = Error **errp) > static void scsi_qdev_unrealize(DeviceState *qdev, Error **errp) > { > SCSIDevice *dev =3D SCSI_DEVICE(qdev); > + Error *local_err =3D NULL; > =20 > if (dev->vmsentry) { > qemu_del_vm_change_state_handler(dev->vmsentry); > } > =20 > + scsi_device_unrealize(dev, &local_err); > + if (local_err) { > + error_propagate(errp, local_err); > + return; > + } > + > scsi_device_purge_requests(dev, SENSE_CODE(NO_SENSE)); (I see this code for the first time, but) I suppose I=E2=80=99d put the scsi_device_unrealize() after scsi_device_purge_requests(). Max > blockdev_mark_auto_del(dev->conf.blk); > } --kLucQT5g4pN9xz331Famfw3jVVHzsLaBf-- --TbT4fuIm9LFAPXCRFLYTOv7SEg52i1AT5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl1TCioACgkQ9AfbAGHV z0DbhAgAn8G++81sexDg57oFo0TjlARLcHBjs/wJLw2LpkW9f4g7EQAwxxPxudLx hU01wgCHds4if/LD9FTZCkzlTy7X+qWnTXC6KUmCJGBz1v/gjr9luv3PfR3xRoFO Wcd0Ao0j5EDyTV2o5yd7o10qx+dCMCTEde9HlrGCpCFKxdPOkKrmclfkXlDfLnM2 rR5Udcgn1GIx5UpJG2FHGZu6M6luLQh0xGQJuKN9XRYY4qU8ja3oL78Fez/D1I1R ZLe2outARTafFnPGb74792suLIN4VdPhwbFrtgRbrFiQil4GqgYNcGOg/Pd5bLrF eBsF+3Q9myi2BGega388Z0hm53llxw== =5lpq -----END PGP SIGNATURE----- --TbT4fuIm9LFAPXCRFLYTOv7SEg52i1AT5--