From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjqck-0004NX-Lf for qemu-devel@nongnu.org; Tue, 13 Sep 2016 12:31:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjqcj-0005CH-Dh for qemu-devel@nongnu.org; Tue, 13 Sep 2016 12:31:54 -0400 References: <20160826091643.15841-1-fullmanet@gmail.com> <20160826091643.15841-7-fullmanet@gmail.com> From: Eric Blake Message-ID: <49ddc272-1f19-aae3-1020-491903c3273e@redhat.com> Date: Tue, 13 Sep 2016 11:31:45 -0500 MIME-Version: 1.0 In-Reply-To: <20160826091643.15841-7-fullmanet@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tnU3hJvAVJ1nw7xNTtppCRPq4EgCcEuDP" Subject: Re: [Qemu-devel] [PATCH v2 6/7] qemu-img: clean up dd documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Reda Sallahi , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tnU3hJvAVJ1nw7xNTtppCRPq4EgCcEuDP From: Eric Blake To: Reda Sallahi , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi Message-ID: <49ddc272-1f19-aae3-1020-491903c3273e@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 6/7] qemu-img: clean up dd documentation References: <20160826091643.15841-1-fullmanet@gmail.com> <20160826091643.15841-7-fullmanet@gmail.com> In-Reply-To: <20160826091643.15841-7-fullmanet@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/26/2016 04:16 AM, Reda Sallahi wrote: > The dd section on qemu-img --help was a bit hard to read since it was n= ot > well aligned. This patch fixes the display problem and also makes the > sentences on the .texi file more consistent with one another (uppercase= and > conjugasion). s/conjugasion/conjugation/ >=20 > Signed-off-by: Reda Sallahi > Reviewed-by: Stefan Hajnoczi > --- > qemu-img.c | 48 +++++++++++++++++++++++++----------------------- > qemu-img.texi | 48 ++++++++++++++++++++++++------------------------ > 2 files changed, 49 insertions(+), 47 deletions(-) >=20 > "List of LEVELS for dd:\n" > - " 'none' surpresses everything but error messages\n" > - " 'noxfer' surpresses the final transfer statistics\n\n" > + " 'none' surpress everything but error messages\n"= > + " 'noxfer' surpress the final transfer statistics\n\= n" s/surpress/suppress/ (twice) > + " 'fsync' physically write output file data before"= > + " finishing\n" > + " 'fdatasync' physically write output file data before"= > + " finishing\n" What's the difference between these two? (fdatasync only flushes file data, while fsync flushes ALL file metadata and is thus stronger. But using the same wording for both lines doesn't make it obvious which one is stronger, and I shouldn't have to resort to 'man fdatasync' to learn the difference). > @item fdatasync > -Synchronize output data just before finishing. This forces a physical = write of output data. > +Synchronizes output data just before finishing. This forces a physical= write of output data. > @item fsync > -Synchronize output data just before finishing. This forces a physical = write of output data. > +Synchronizes output data just before finishing. This forces a physical= write of output data. Again, mention which version is stronger. > @item excl > -Err if the output file already exists. > +Errs if the output file already exists. s/Errs/Raises an error/ > @item nocreat > -Do not create the output file; the output file must already exist. > +Does not create the output file; the output file must already exist. > @item sparse > -Seek rather than write NUL output blocks. > +Seeks rather than write NUL output blocks. > =20 > @item iflag=3D@var{flags} > -defines the flags used to read the input file. The flag list is seprat= ed using > +Defines the flags used to read the input file. The flag list is seprat= ed using s/seprated/separated/ > commas. > @item oflag=3D@var{flags} > -defines the flags used to write the output file. The flag list is sepr= ated > +Defines the flags used to write the output file. The flag list is sepr= ated and again > using commas. > =20 > The flag list: > @item direct > -direct I/O for data. > +Direct I/O for data. > @item dsync > -synchronised I/O for data. > +Synchronised I/O for data. Do we have a strong preference for US (-ized) vs. UK (-ised) spelling elsewhere in this document? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tnU3hJvAVJ1nw7xNTtppCRPq4EgCcEuDP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2CnxAAoJEKeha0olJ0NqHj4IAInc/YJTu1LF3CoZFP/1JhOx Q7FufQif0IVe7WJ9qOuSX5sWpqZ0JZo6frGX2ivWisHVKSCYokvbyQG/OoxRCWPk frLOwrgBYO3dZTz9WI8jLgeuisfojYRaUV+mIMAObh/Kx0twunAXikkqyvYC9CqC 8Ox+GhVNaXXuMhcgY1PK2zpHk6NjjWOrmUZioDEUpDYnHQBtKEOBPgHGttdt4Jgs bx6+CYQLCtm/FLt4mYZ9ByZYYxeHjHx5ljGxIFf7KImeUBsgrg506hNTTe+rnZyC 0BcxZHFNZW824nSchcNyCZ918LdQR/rgFKFvjB+G7+JqouQHuvdpjZ2313v9Fbo= =bsWb -----END PGP SIGNATURE----- --tnU3hJvAVJ1nw7xNTtppCRPq4EgCcEuDP--