From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH] contrib/plugins: add Darwin support
Date: Thu, 7 Sep 2023 14:30:44 +0200 [thread overview]
Message-ID: <49e0cd0d-bc6a-db43-8eae-11f6c84b729b@linaro.org> (raw)
In-Reply-To: <20230907114403.493361-1-pbonzini@redhat.com>
On 7/9/23 13:44, Paolo Bonzini wrote:
> Under Darwin, using -shared makes it impossible to have undefined symbols
> and -bundle has to be used instead; so detect the OS and use
> different options.
>
> Based-on: <20230907101811.469236-1-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> This replaces Philippe's patch to link with GLib, and also fixes
> errors like
>
> "_qemu_plugin_get_hwaddr", referenced from:
> _vcpu_mem in execlog.o
>
> I guess this shows that we're kinda losing in not using Meson
> for the plugins, but as I said I appreciate the didactic value
> of using a standalone Makefile (with only a handful of lines
> in configure).
>
> contrib/plugins/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-09-07 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 11:44 [PATCH] contrib/plugins: add Darwin support Paolo Bonzini
2023-09-07 12:30 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e0cd0d-bc6a-db43-8eae-11f6c84b729b@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).