From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF03C433B4 for ; Sun, 25 Apr 2021 03:36:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9B9E6120F for ; Sun, 25 Apr 2021 03:36:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9B9E6120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laVZn-0003Cu-Lk for qemu-devel@archiver.kernel.org; Sat, 24 Apr 2021 23:36:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laVY5-0002H6-Uk for qemu-devel@nongnu.org; Sat, 24 Apr 2021 23:35:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laVXz-0007Ch-FV for qemu-devel@nongnu.org; Sat, 24 Apr 2021 23:35:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619321702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0vvTDQrI/BLjNFn5a9oq7MBRdmikW8HVS6GjhjmOXE=; b=TMONfNSk73Q0JtaXQbNl5eacCR/Gi91IoAPzc93xqeTMskfMd3rYM25E4lbU6aWZRuqaBp xiiB91jBZJ/kDV/oieHScykKwUPPSprnSzPXxFpWoGbzyjDy8jnYwmPCmlmgOnraiOrMbl M7uSMUjrmUENRdk300HxCJLciD3tpLs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-526-e0njqMtDNM23QRHGeXK4WA-1; Sat, 24 Apr 2021 23:34:59 -0400 X-MC-Unique: e0njqMtDNM23QRHGeXK4WA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1440B10054F6 for ; Sun, 25 Apr 2021 03:34:59 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-12-56.pek2.redhat.com [10.72.12.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39FE260BF1 for ; Sun, 25 Apr 2021 03:34:57 +0000 (UTC) Subject: Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA To: qemu-devel@nongnu.org References: <20210423044713.3403-1-dongli.zhang@oracle.com> <25113515-5c1d-c557-d0cc-04bfacecb6ee@redhat.com> <8aad1273-5c17-a2d7-46cd-eb149c6c57b8@oracle.com> From: Jason Wang Message-ID: <49e9dbb6-8fba-839e-5eed-38703874bae1@redhat.com> Date: Sun, 25 Apr 2021 11:34:55 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <8aad1273-5c17-a2d7-46cd-eb149c6c57b8@oracle.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_CHARSET_FARAWAY=2.45, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2021/4/24 上午1:26, Dongli Zhang 写道: > > On 4/22/21 11:01 PM, Jason Wang wrote: >> 在 2021/4/23 下午12:47, Dongli Zhang 写道: >>> This is inspired by the discussion with Jason on below patchset. >>> >>> https://urldefense.com/v3/__https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html__;!!GqivPVa7Brio!KbGQZW5lq3JZ60k12NuWZ6Th1lT6AwmBTF0pBgoWUKKQ4-2UhdW57PtvXUN5XQnZ2NU$ >>> >>> The new HMP command is introduced to dump the MSI-X table and PBA. >>> >>> Initially, I was going to add new option to "info pci". However, as the >>> number of entries is not determined and the output of MSI-X table is much >>> more similar to the output of hmp_info_tlb()/hmp_info_mem(), this patch >>> adds interface for only HMP. >>> >>> The patch is tagged with RFC because I am looking for suggestions on: >>> >>> 1. Is it fine to add new "info msix " command? >> >> I wonder the reason for not simply reusing "info pci"? > The "info pci" will show PCI data for all devices and it does not accept any > argument to print for a specific device. > > In addition, the "info pci" relies on qmp_query_pci(), where this patch will not > implement the interface for QMP considering the number of MSI-X entries is not > determined. > > Suppose we have 10 NVMe (emulated by QEMU with default number of queues), we > will have about 600+ lines of output. I see. Thanks > > Dongli Zhang > >> >>> 2. Is there any issue with output format? >> >> If it's not for QMP, I guess it's not a part of ABI so it should be fine. >> >> >>> 3. Is it fine to add only for HMP, but not QMP? >> >> I think so. >> >> Thanks >> >> >>> Thank you very much! >>> >>> Dongli Zhang >>> >>> >>>