From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A163C3ABB2 for ; Wed, 28 May 2025 12:12:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKFdn-0003li-8K; Wed, 28 May 2025 08:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFdF-0003Ic-1k; Wed, 28 May 2025 08:11:43 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFdA-0003Me-O0; Wed, 28 May 2025 08:11:40 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54S2M8p3004256; Wed, 28 May 2025 12:11:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=xZOFpJ Fz2Lj292MJ5VMzI0LYOuslKb8V+4/F6cPVqtU=; b=Da1i1I3ckzPvWZgPvV1wWR 9uaHWh5hjd8RbTlnnersUnMN7svHo+gvrUikgBC4n1WThWuwF9TZDa3+06u9MhtX KA9HqvqaZb3BCU91trch5xXvk859Gawb2RwPopihwjW3K4xTY9IKup9D5E/7I6ZD XUzf61m99MqLQetg57Cxz1eLJqUyGAlbNL0TGImBK5UnwEUkshO8T2BEdxLFI798 Yh00cp1pdlg+Yg9RPl9h0BQ04zK8thF6fSmLy9SyfhNHcZCXGRymtyQTWb3ERi8/ LFT3v/zolNRqV9w/kv6UxE0Ac+dDXgCviU4y2v8hQwU4rtaXkAYFvY1QcKkV2KXg == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46wgsjcn5t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 May 2025 12:11:33 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54SAl08H016202; Wed, 28 May 2025 12:11:32 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46uru0qgnh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 May 2025 12:11:32 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54SCBUNV918050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 May 2025 12:11:31 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C67485803F; Wed, 28 May 2025 12:11:30 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 349D45804E; Wed, 28 May 2025 12:11:30 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 28 May 2025 12:11:30 +0000 (GMT) MIME-Version: 1.0 Date: Wed, 28 May 2025 14:11:29 +0200 From: Shalini Chellathurai Saroja To: Hendrik Brueckner Cc: Thomas Huth , Nina Schoetterl-Glausch , qemu-s390x mailing list , Daniel Berrange , qemu-devel mailing list Subject: Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI In-Reply-To: References: <5077ebbe-5a4d-4db5-8a1d-067d88244bfb@redhat.com> <2d53cf272ae58736b7904c9a86a2a1ce@linux.ibm.com> Message-ID: <49ed179670e9ca3e90aad32a3fd4b498@linux.ibm.com> X-Sender: shalini@linux.ibm.com Organization: IBM Deutschland Research & Development GmbH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Qspe3Uyd c=1 sm=1 tr=0 ts=6836fd75 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=O_Pf07f7kNC-Rk50P3UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI4MDEwNSBTYWx0ZWRfX2UZyghuSVlU/ 2crrXiarIhs2sKGBKlp/igQV1igKBFTe1NzDo9eRQOy+GFdKiVwsKAW+pNJvqumTp0ny8YQqjxK lthGsdQhYHnQ0JOGbnGvH6iwj6EjOjAK7lvMwJu8TgiifdRP4CMz8DY8XUWdGQvR9JvH7ANl2iL C36v5AJduxOeyYz36SEVGbtZCj07zFTkFk5zxmw301SALRzME2jQeyF+GpnyT4vgZj70duVXJzM BaHYWXwGbcWTDy/M35FXKZpsT87AFW0nsWz/CkM7T/5guyLb6zVAZIYgKgVmiGOpcO50IUsJmPH SgsB/0xW+urJMHYJW1VRN1iV/jmkMKibvmsN8YnPFcEn8qfvHPRopU6+Zlp7HbN2ioVlCfzOAFG yBKmvjkqNg1tseywkJvkFQ0kor0HBV6P2ba/WLi9LK38ABh+q3DUVVTJGyMT3FC3FV+LOhTA X-Proofpoint-ORIG-GUID: KnvChyDYsqpoJDkxrBYRtaTQjzsnsN35 X-Proofpoint-GUID: KnvChyDYsqpoJDkxrBYRtaTQjzsnsN35 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-28_06,2025-05-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505280105 Received-SPF: pass client-ip=148.163.158.5; envelope-from=shalini@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2025-05-23 14:07, Hendrik Brueckner wrote: > On Tue, May 06, 2025 at 02:16:18PM +0200, Shalini Chellathurai Saroja > wrote: >> On 2025-05-06 09:48, Thomas Huth wrote: >> > On 06/05/2025 08.48, Nina Schoetterl-Glausch wrote: >> > > On Mon, 2025-05-05 at 08:55 +0200, Shalini Chellathurai Saroja wrote: >> > > > On 2025-04-28 11:22, Janis Schoetterl-Glausch wrote: >> > > > > On Thu, 2025-04-10 at 17:09 +0200, Shalini Chellathurai >> > > > > Saroja wrote: >> > > > > > Implement the Service-Call Logical Processor (SCLP) event >> > > > > > type Control-Program Identification (CPI) in QEMU. This >> > > > > > event is used to send CPI identifiers from the guest to the >> > > > > > host. The CPI identifiers are: system type, system name, >> > > > > > system level and sysplex name. >> > > > > > >> > > > > > System type: operating system of the guest (e.g. "LINUX"). >> > > > > > System name: user configurable name of the guest (e.g. "TESTVM"). >> > > > > > System level: distribution and kernel version, if the >> > > > > > system type is >> > > > > > Linux >> > > > > > (e.g. 0x50e00). >> > > > > > Sysplex name: name of the cluster which the guest >> > > > > > belongs to (if any) >> > > > > > (e.g. "PLEX"). >> > > > > > >> > > > > > Signed-off-by: Shalini Chellathurai Saroja >> > > > > > Reviewed-by: Thomas Huth >> > > > > > --- >> > > > > > hw/s390x/event-facility.c | 2 + >> > > > > > hw/s390x/meson.build | 1 + >> > > > > > hw/s390x/s390-virtio-ccw.c | 14 +++++ >> > > > > > hw/s390x/sclpcpi.c | 92 >> > > > > > +++++++++++++++++++++++++++++++ >> > > > > > include/hw/s390x/event-facility.h | 13 +++++ >> > > > > > 5 files changed, 122 insertions(+) >> > > > > > create mode 100644 hw/s390x/sclpcpi.c >> > > > > > >> > > > > > diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c >> > > > > > index 2b0332c20e..60237b8581 100644 >> > > > > > --- a/hw/s390x/event-facility.c >> > > > > > +++ b/hw/s390x/event-facility.c >> > > >> > > [...] >> > > >> > > > It is possible to add the identifiers directly as the properties of >> > > > sclpcpi (eg. system type as shown below) and remove the >> > > > control-program-id. >> > > >> > > This is what I meant, drop it from qom. >> >> Ok. >> >> > > > >> > > > virsh # qemu-monitor-command vm --pretty >> > > > '{"execute":"qom-list","arguments": {"path": >> > > > "/machine/sclp/s390-sclp-event-facility/sclpcpi"}}' >> > > > { >> > > > "return": [ >> > > > { >> > > > "name": "type", >> > > > "type": "string" >> > > > }, >> > > > { >> > > > "name": "parent_bus", >> > > > "type": "link" >> > > > }, >> > > > { >> > > > "name": "realized", >> > > > "type": "bool" >> > > > }, >> > > > { >> > > > "name": "hotplugged", >> > > > "type": "bool" >> > > > }, >> > > > { >> > > > "name": "hotpluggable", >> > > > "type": "bool" >> > > > }, >> > > > { >> > > > "name": "system_type", >> > > > "type": "string" >> > > > }, >> > > > { >> > > > "name": "control-program-id", >> > > > "type": "S390ControlProgramId" >> > > > } >> > > > ], >> > > > "id": "libvirt-16" >> > > > } >> > > > >> > > > virsh # qemu-monitor-command vm --pretty '{"execute":"qom-get", >> > > > "arguments":{"path":"/machine/sclp/s390-sclp-event-facility/sclpcpi", >> > > > "property":"system_type"}}' >> > > > { >> > > > "return": "LINUX ", >> > > > "id": "libvirt-17" >> > > > } >> > > > >> > > > However, Hendrik Brückner suggested to group the identifiers together >> > > > during the initial discussion of this line item. So, I would >> > > > prefer to >> > > >> > > They are grouped together under "sclpcpi", no? >> >> Yes. >> >> > > >> > > > leave this as it is. Please let me know if you still think otherwise. >> > > >> > > I don't have a strong opinion on this, just wanted to mention it and >> > > see what other people say. >> > >> > I guess it mostly depends on whether there are future plans for using >> > the QOM type elsewhere. If this type is supposed to be used in other >> > QAPI calls in the future, it makes sense to keep it separate now. If >> > there are no such plans, it's maybe easier to integrate the values >> > into sclpcpi directly. Hendrik, any opinion from your side? >> > >> > Thomas >> >> Hello Hendrik, >> >> I have provided the output of both the options below. Please let me >> know >> which option do you prefer. >> >> I have incorporated the other comments. So I will be able to send V5 >> after >> your response. Thank you very much! >> >> Option 1: Control-program identifiers set as the properties of >> sclpcpi: >> >> virsh # qemu-monitor-command vm --pretty >> '{"execute":"qom-list","arguments": >> {"path": "/machine/sclp/s390-sclp-event-facility/sclpcpi"}}' >> { >> "return": [ >> { >> [...] >> }, >> { >> "name": "system_level", >> "type": "uint64" >> }, >> { >> "name": "system_name", >> "type": "string" >> }, >> { >> "name": "system_type", >> "type": "string" >> }, >> { >> "name": "timestamp", >> "type": "uint64" >> }, >> { >> "name": "sysplex_name", >> "type": "string" >> } >> ], >> "id": "libvirt-14" >> } > > I would vote for Option 1 as this seems to be a bit more natural from > an object model. There is not much impact for the upcoming changes > to consume this information. Hello Hendrik, Ok, I will incorporate this and will send the next version of this series. Thank you very much! -- Mit freundlichen Grüßen / Kind regards Shalini Chellathurai Saroja Software Developer Linux on IBM Z & KVM Development IBM Deutschland Research & Development GmbH Dept 1419, Schoenaicher Str. 220, 71032 Boeblingen Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294