From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Lenard Szolnoki <blog@lenardszolnoki.com>
Subject: Re: [PATCH] target/i386: fix operand order for PDEP and PEXT
Date: Tue, 24 Nov 2020 20:44:33 +0100 [thread overview]
Message-ID: <49f0103c-eef4-5458-b222-14a63ab01cfe@redhat.com> (raw)
In-Reply-To: <ee22951a-6e40-67d4-c0b0-7df096572ea5@linaro.org>
On 24/11/20 18:54, Richard Henderson wrote:
>> +test-i386-bmi2: CFLAGS += -mbmi2
>> +run-test-i386-bmi2: QEMU_OPTS += -cpu max
>> +run-plugin-test-i386-bmi2-%: QEMU_OPTS += -cpu max
> I suspect that we still support host operating systems whose compilers do not
> support -mbmi2. This might require a bit in tests/tcg/configure.sh akin to
> CROSS_CC_HAS_ARMV8_3.
>
Actually -mbmi2 should not be needed since (unlike sse or avx) the
instructions use normal registers. Only the assembler matters, and at
least RHEL7 (binutils 2.27) has them. So I'll just remove the flag, it
should be enough.
Paolo
prev parent reply other threads:[~2020-11-24 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:14 [PATCH] target/i386: fix operand order for PDEP and PEXT Paolo Bonzini
2020-11-23 13:21 ` no-reply
2020-11-24 17:54 ` Richard Henderson
2020-11-24 19:44 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f0103c-eef4-5458-b222-14a63ab01cfe@redhat.com \
--to=pbonzini@redhat.com \
--cc=blog@lenardszolnoki.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).