qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Bibo Mao" <maobibo@loongson.cn>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Song Gao" <gaosong@loongson.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] hw/loongarch/virt: Get physical entry address with elf file
Date: Fri, 25 Apr 2025 08:33:45 -0700	[thread overview]
Message-ID: <49fafb18-2186-4d19-867b-bc26c1c43572@linaro.org> (raw)
In-Reply-To: <20250425021620.3968737-1-maobibo@loongson.cn>

On 4/24/25 19:16, Bibo Mao wrote:
> With load_elf() api, image load low address and high address is converted
> to physical address if parameter translate_fn is provided. However
> executing entry address is still virtual address. Here convert entry
> address into physical address, since MMU is disabled when system power on,
> the first PC instruction should be physical address.
> 
> Signed-off-by: Bibo Mao<maobibo@loongson.cn>
> ---
>    v1 ... v2:
>    1. Only modify LoongArch specified rather than load_elf() API, since
>       there is be potential influence with other architectures.
> ---
>   hw/loongarch/boot.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Although perhaps we should adjust the API because all users have to do exactly this, and 
it's easy to miss.


r~


  reply	other threads:[~2025-04-25 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25  2:16 [PATCH v2] hw/loongarch/virt: Get physical entry address with elf file Bibo Mao
2025-04-25 15:33 ` Richard Henderson [this message]
2025-04-27  8:34   ` bibo mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49fafb18-2186-4d19-867b-bc26c1c43572@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).