From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1HKg-0003r9-VN for qemu-devel@nongnu.org; Tue, 05 May 2009 05:53:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1HKc-0003nl-20 for qemu-devel@nongnu.org; Tue, 05 May 2009 05:53:02 -0400 Received: from [199.232.76.173] (port=54244 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1HKb-0003ni-Sm for qemu-devel@nongnu.org; Tue, 05 May 2009 05:52:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59999) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1HKb-0000Ku-Br for qemu-devel@nongnu.org; Tue, 05 May 2009 05:52:57 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n459qttQ018222 for ; Tue, 5 May 2009 05:52:55 -0400 Message-ID: <4A000C74.5020907@redhat.com> Date: Tue, 05 May 2009 12:52:52 +0300 From: Avi Kivity MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Strange virtio regression on mainline and stable-0.10 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel Running the Fedora 10 installer on a virtio disk on current master and on v0.10.3 will cause the installer to complain when mounting the freshly formatted filesystems. A bisect (on stable-0.10) yielded 4df8f71ee5276fb22a810bbb67db3a4288f5cad4 is first bad commit commit 4df8f71ee5276fb22a810bbb67db3a4288f5cad4 Author: aliguori Date: Fri Apr 17 20:44:41 2009 +0000 qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf) This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables are big endian, so entries must be converted before being passed to functions. This bug is easy to trigger. The following script will create and destroy a qcow2 image (the header is gone after three loop iterations): #!/bin/bash qemu-img create -f qcow2 test.qcow 1M for i in $(seq 1 10); do qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 < Signed-off-by: Anthony Liguori As the guilty commit. I don't understand it, as free_any_clusters() shouldn't be called while formatting. Any ideas? -- error compiling committee.c: too many arguments to function