From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1K6g-0005ZK-T3 for qemu-devel@nongnu.org; Tue, 05 May 2009 08:50:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1K6Y-0005Y4-H1 for qemu-devel@nongnu.org; Tue, 05 May 2009 08:50:44 -0400 Received: from [199.232.76.173] (port=34690 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1K6Y-0005Y1-A2 for qemu-devel@nongnu.org; Tue, 05 May 2009 08:50:38 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60189) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1K6X-0003z9-CF for qemu-devel@nongnu.org; Tue, 05 May 2009 08:50:38 -0400 Message-ID: <4A003612.4010405@redhat.com> Date: Tue, 05 May 2009 14:50:26 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free References: <1241519517.2162.6.camel@system> In-Reply-To: <1241519517.2162.6.camel@system> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: vibi_sreenivasan@cms.com Cc: qemu-devel@nongnu.org Hi, > - path = malloc(len+1); > + path = qemu_malloc(len+1); > snprintf(path, len+1, "%.*s", len, str); > } else > path = strdup(str); You need s/strdup/qemu_strdup/ here (and maybe elsewhere too), otherwise you'll mix strdup + qemu_free(). cheers, Gerd