qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Strange virtio regression on mainline and stable-0.10
Date: Wed, 06 May 2009 10:14:27 +0200	[thread overview]
Message-ID: <4A0146E3.2090909@redhat.com> (raw)
In-Reply-To: <4A0066D9.6030008@redhat.com>

Avi Kivity schrieb:
> Avi Kivity wrote:
>> Running the Fedora 10 installer on a virtio disk on current master and 
>> on v0.10.3 will cause the installer to complain when mounting the 
>> freshly formatted filesystems.
> 
> The problem is that qcow2 does a read-modify-write on 
> non-cluster-aligned writes.  So the following sequence triggers the bug:
> [...]
> 
> This could be solved by maintaining a hash table of refcounted RMW 
> copies for the disk.  When reading for a RMW, look up the hash table, if 
> there's a copy there, use it instead of reading it yourself.
> 
> We should also avoid the RMW for non-compressed, non-encrypted clusters, 
> as virtually ALL writes will be misaligned.

I don't think there is a RMW except for the COW case which is
unavoidable and obviously happens only once for each cluster. Do you see
any other places where this happens?

Kevin

  parent reply	other threads:[~2009-05-06  8:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  9:52 [Qemu-devel] Strange virtio regression on mainline and stable-0.10 Avi Kivity
2009-05-05 10:03 ` [Qemu-devel] " Avi Kivity
     [not found] ` <4A001563.1020604@redhat.com>
2009-05-05 11:46   ` Avi Kivity
2009-05-05 16:18 ` [Qemu-devel] " Avi Kivity
2009-05-05 18:18   ` Avi Kivity
2009-05-06  8:14   ` Kevin Wolf [this message]
2009-05-06  8:34     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0146E3.2090909@redhat.com \
    --to=kwolf@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).