From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1dDp-0007ln-U3 for qemu-devel@nongnu.org; Wed, 06 May 2009 05:15:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1dDk-0007iQ-UV for qemu-devel@nongnu.org; Wed, 06 May 2009 05:15:25 -0400 Received: from [199.232.76.173] (port=52053 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1dDk-0007iL-Mw for qemu-devel@nongnu.org; Wed, 06 May 2009 05:15:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51660) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1dDk-0006wD-AL for qemu-devel@nongnu.org; Wed, 06 May 2009 05:15:20 -0400 Message-ID: <4A0154E9.7020705@redhat.com> Date: Wed, 06 May 2009 11:14:17 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> In-Reply-To: <20090506082810.GB23167@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: alex@csgraf.de, nolan@sigbus.net, qemu-devel@nongnu.org Daniel P. Berrange schrieb: > On Wed, May 06, 2009 at 03:00:50AM +0200, alex@csgraf.de wrote: >> From: Alexander Graf >> >> Currently Qemu can read from posix I/O and NBD. This patch adds a >> third protocol to the game: HTTP. >> >> In certain situations it can be useful to access HTTP data directly, >> for example if you want to try out an http provided OS image, but >> don't know if you want to download it yet. >> >> Using this patch you can now try it on on the fly. Just use it like: >> >> qemu -cdrom http://host/path/my.iso > > I rather think there should be an explicit flag to allow use of http:// > URLs in filenames at runtime, not just 'configure' time. There are many > apps out there using QEMU which will be assuming QEMU treats all disk > paths as local files, and thus not got explicit code to check whether > a URI is passed. I could well see that some will consider it a security > issue to allow QEMU to download off the net, but if they updated to > a new QEMU with this patch, downloading would be allowed by default. If apps want to be sure that they are accessing a local file, they must ensure not to have a colon in the file name. Otherwise this specifies a protocol for the qemu block layer. Btw, we could use a way to escape colons in a file name. Using such files isn't possible currently. > Perhaps only enable these remote URIs with the -drive parameter, when > an explicit fmt=http option is set. But can this be layered into the > other protocols, eg could the remote URI be in qcow, vmdk, etc formats, > or are you assuming the remote uri is raw file ? It should work with all formats. This is why fmt=http is wrong. It's not a format, but a protocol. Kevin