From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1hfG-0007Ga-KW for qemu-devel@nongnu.org; Wed, 06 May 2009 10:00:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1hfB-0007B5-Df for qemu-devel@nongnu.org; Wed, 06 May 2009 10:00:01 -0400 Received: from [199.232.76.173] (port=49319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1hfB-0007Au-AD for qemu-devel@nongnu.org; Wed, 06 May 2009 09:59:57 -0400 Received: from an-out-0708.google.com ([209.85.132.250]:11091) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1hfA-0001vI-RA for qemu-devel@nongnu.org; Wed, 06 May 2009 09:59:57 -0400 Received: by an-out-0708.google.com with SMTP id d11so58626and.37 for ; Wed, 06 May 2009 06:59:56 -0700 (PDT) Message-ID: <4A0197D9.9010109@codemonkey.ws> Date: Wed, 06 May 2009 08:59:53 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> <4A0154E9.7020705@redhat.com> <20090506093143.GC23167@redhat.com> <4A015F06.7050102@redhat.com> <4A018CD8.6000200@codemonkey.ws> <20090506133920.GK23167@redhat.com> <4A0195A3.7090205@redhat.com> In-Reply-To: <4A0195A3.7090205@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: alex@csgraf.de, nolan@sigbus.net, Avi Kivity , qemu-devel@nongnu.org Kevin Wolf wrote: > Daniel P. Berrange schrieb: > >> All I care about from libvirt POV, is that there is a way to give QEMU an >> absolute file path for a disk, and guarentee that QEMU will treat this as >> a local file path, and not try any access protocols, other than 'open(2)'. >> Various options from this thread.... >> >> - Treat any path starting with / as local file >> - Allow file: as a prefix >> - Allow file:/// as a prefix, real URI style >> - Add a protocol=file flag to -drive >> >> Pick one, pick several, suggest more. Any of these options would work as >> far as I'm concerned, and we could easily support several. I think the >> first is desirable because that's the natural thing users will try when >> launching QEMU directly. >> > > I think we all agree that file: is a reasonable option for libvirt which > covers all cases of colons (even relative paths starting with http:), so > let's take this one. If you want to magically do the right thing for > users invoking qemu manually, I think we should rather go for: > I've changed my mind. I think file: makes the situation worse because it gives a false sense of security. If you just pass file: you are broken. You still have to escape commas. If you're escaping commas, you might as well escape colons too. I think escaping is the only complete solution. Regards, Anthony Liguori