From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: alex@csgraf.de, nolan@sigbus.net, Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2
Date: Wed, 06 May 2009 16:11:19 +0200 [thread overview]
Message-ID: <4A019A87.7090505@redhat.com> (raw)
In-Reply-To: <4A0197D9.9010109@codemonkey.ws>
Anthony Liguori schrieb:
> I've changed my mind. I think file: makes the situation worse because
> it gives a false sense of security. If you just pass
> file:<user-inputed-filename> you are broken. You still have to escape
> commas. If you're escaping commas, you might as well escape colons too.
>
> I think escaping is the only complete solution.
You're completely right if we don't limit the discussion to colons. I'm
not sure if breaking colons really makes tools aware that they need to
take care of commas, but "it's broken anyway" is a reasonable answer if
we can have a generic fix (and we can have it here).
So what should the generic escaping look like?
And I still think we should do something about colons, they are much
more common in paths than commas. Even more so on Windows, I guess.
Should we still implement the strategy "anything that isn't a valid
protocol must be a local file"?
Kevin
next prev parent reply other threads:[~2009-05-06 14:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 1:00 [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 alex
2009-05-06 8:28 ` Daniel P. Berrange
2009-05-06 9:14 ` Kevin Wolf
2009-05-06 9:31 ` Daniel P. Berrange
2009-05-06 9:40 ` Alexander Graf
2009-05-06 9:57 ` Avi Kivity
2009-05-06 10:00 ` Kevin Wolf
2009-05-06 10:06 ` Daniel P. Berrange
2009-05-06 10:13 ` Daniel P. Berrange
2009-05-06 10:15 ` Avi Kivity
2009-05-06 10:15 ` Alexander Graf
2009-05-06 13:11 ` Anthony Liguori
2009-05-06 10:16 ` Kevin Wolf
2009-05-06 10:23 ` Alexander Graf
2009-05-06 10:24 ` Daniel P. Berrange
2009-05-06 10:09 ` Alexander Graf
2009-05-06 13:09 ` Anthony Liguori
2009-05-06 13:59 ` Avi Kivity
2009-05-06 14:08 ` Anthony Liguori
2009-05-06 14:14 ` François Revol
2009-05-06 13:12 ` Anthony Liguori
2009-05-06 13:39 ` Daniel P. Berrange
2009-05-06 13:43 ` Anthony Liguori
2009-05-06 13:50 ` Kevin Wolf
2009-05-06 13:59 ` Anthony Liguori
2009-05-06 14:11 ` Kevin Wolf [this message]
2009-05-06 14:39 ` Anthony Liguori
2009-05-06 14:48 ` Alexander Graf
2009-05-06 14:49 ` Avi Kivity
2009-05-06 16:51 ` Anthony Liguori
2009-05-08 17:00 ` Jamie Lokier
2009-05-06 14:49 ` Kevin Wolf
2009-05-06 13:08 ` Anthony Liguori
2009-05-06 10:43 ` Jamie Lokier
2009-05-06 12:59 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A019A87.7090505@redhat.com \
--to=kwolf@redhat.com \
--cc=alex@csgraf.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=nolan@sigbus.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).