From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1hrK-0003kA-3H for qemu-devel@nongnu.org; Wed, 06 May 2009 10:12:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1hrE-0003hZ-VP for qemu-devel@nongnu.org; Wed, 06 May 2009 10:12:29 -0400 Received: from [199.232.76.173] (port=50686 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1hrE-0003hT-E8 for qemu-devel@nongnu.org; Wed, 06 May 2009 10:12:24 -0400 Received: from mx20.gnu.org ([199.232.41.8]:2160) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M1hrE-00087s-4M for qemu-devel@nongnu.org; Wed, 06 May 2009 10:12:24 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1hrD-0001tl-Fv for qemu-devel@nongnu.org; Wed, 06 May 2009 10:12:23 -0400 Message-ID: <4A019A87.7090505@redhat.com> Date: Wed, 06 May 2009 16:11:19 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> <4A0154E9.7020705@redhat.com> <20090506093143.GC23167@redhat.com> <4A015F06.7050102@redhat.com> <4A018CD8.6000200@codemonkey.ws> <20090506133920.GK23167@redhat.com> <4A0195A3.7090205@redhat.com> <4A0197D9.9010109@codemonkey.ws> In-Reply-To: <4A0197D9.9010109@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: alex@csgraf.de, nolan@sigbus.net, Avi Kivity , qemu-devel@nongnu.org Anthony Liguori schrieb: > I've changed my mind. I think file: makes the situation worse because > it gives a false sense of security. If you just pass > file: you are broken. You still have to escape > commas. If you're escaping commas, you might as well escape colons too. > > I think escaping is the only complete solution. You're completely right if we don't limit the discussion to colons. I'm not sure if breaking colons really makes tools aware that they need to take care of commas, but "it's broken anyway" is a reasonable answer if we can have a generic fix (and we can have it here). So what should the generic escaping look like? And I still think we should do something about colons, they are much more common in paths than commas. Even more so on Windows, I guess. Should we still implement the strategy "anything that isn't a valid protocol must be a local file"? Kevin