From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1iI6-0001f5-1R for qemu-devel@nongnu.org; Wed, 06 May 2009 10:40:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1iI0-0001cz-HS for qemu-devel@nongnu.org; Wed, 06 May 2009 10:40:09 -0400 Received: from [199.232.76.173] (port=42073 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1iI0-0001ci-EU for qemu-devel@nongnu.org; Wed, 06 May 2009 10:40:04 -0400 Received: from mx20.gnu.org ([199.232.41.8]:3923) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M1iI0-00079k-2n for qemu-devel@nongnu.org; Wed, 06 May 2009 10:40:04 -0400 Received: from yx-out-1718.google.com ([74.125.44.153]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1iHz-0003QG-HG for qemu-devel@nongnu.org; Wed, 06 May 2009 10:40:03 -0400 Received: by yx-out-1718.google.com with SMTP id 6so64026yxn.82 for ; Wed, 06 May 2009 07:40:02 -0700 (PDT) Message-ID: <4A01A13F.6070001@codemonkey.ws> Date: Wed, 06 May 2009 09:39:59 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> <4A0154E9.7020705@redhat.com> <20090506093143.GC23167@redhat.com> <4A015F06.7050102@redhat.com> <4A018CD8.6000200@codemonkey.ws> <20090506133920.GK23167@redhat.com> <4A0195A3.7090205@redhat.com> <4A0197D9.9010109@codemonkey.ws> <4A019A87.7090505@redhat.com> In-Reply-To: <4A019A87.7090505@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: alex@csgraf.de, nolan@sigbus.net, Avi Kivity , qemu-devel@nongnu.org Kevin Wolf wrote: > Anthony Liguori schrieb: > >> I've changed my mind. I think file: makes the situation worse because >> it gives a false sense of security. If you just pass >> file: you are broken. You still have to escape >> commas. If you're escaping commas, you might as well escape colons too. >> >> I think escaping is the only complete solution. >> > > You're completely right if we don't limit the discussion to colons. I'm > not sure if breaking colons really makes tools aware that they need to > take care of commas, but "it's broken anyway" is a reasonable answer if > we can have a generic fix (and we can have it here). > If we have escaping, I'm happy to consider file: if people still think it's useful. But adding file: without escaping is IMHO dangerous. > So what should the generic escaping look like? > -drive file=my-silly\:filename\,with\ strange\ characters I see no reason to do anything overly complicated. Of course, if you're in a shell, you'll have to double escape unless you've got single quotes around it. That's a good argument for file: in addition to escaping. Regards, Anthony Liguori