From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
Jes Sorensen <jes@sgi.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled
Date: Thu, 07 May 2009 14:00:41 +0300 [thread overview]
Message-ID: <4A02BF59.6030103@redhat.com> (raw)
In-Reply-To: <4A02BD27.5050401@siemens.com>
Jan Kiszka wrote:
>> In upstream. Please fix it in upstream and qemu-kvm.git will get the
>> fix from there.
>>
>
> Given that CONFIG_GDBSTUB is always true upstream, I tend to say:
> Finally drop it upstream and keep this (or a more arch-local) workaround
> for missing ia64 gdbstub support downstream.
>
I agree, unless
- we want to make gdbstub support configurable (don't see any
overwhelming reason for this, but maybe others do)
- we want to merge ia64 kvm support upstream, and don't want to impose
gdbstub support (though I'd recommend properly implementing gdbstub)
In any case, I'm okay with dropping the check upstream and applying the
local fixup.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-07 11:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A01AFE8.3020008@sgi.com>
[not found] ` <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com>
[not found] ` <4A02AA81.90809@redhat.com>
2009-05-07 10:51 ` [Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled Jan Kiszka
2009-05-07 11:00 ` Avi Kivity [this message]
2009-05-07 11:13 ` Jan Kiszka
2009-05-07 11:28 ` Avi Kivity
2009-05-07 11:38 ` Jan Kiszka
2009-05-07 12:34 ` Jes Sorensen
2009-05-07 12:59 ` Jan Kiszka
2009-05-07 13:03 ` Jes Sorensen
2009-05-07 13:07 ` Jan Kiszka
2009-05-07 13:31 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A02BF59.6030103@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).