From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M21YP-0002It-Aa for qemu-devel@nongnu.org; Thu, 07 May 2009 07:14:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M21YK-0002Fe-2Q for qemu-devel@nongnu.org; Thu, 07 May 2009 07:14:16 -0400 Received: from [199.232.76.173] (port=58900 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M21YJ-0002FK-LJ for qemu-devel@nongnu.org; Thu, 07 May 2009 07:14:11 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:17373) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M21YG-0002Fq-Ku for qemu-devel@nongnu.org; Thu, 07 May 2009 07:14:09 -0400 Message-ID: <4A02C277.4000402@siemens.com> Date: Thu, 07 May 2009 13:13:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com> <4A02BF59.6030103@redhat.com> In-Reply-To: <4A02BF59.6030103@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: "kvm-ia64@vger.kernel.org" , Jes Sorensen , "kvm@vger.kernel.org" , qemu-devel Avi Kivity wrote: > Jan Kiszka wrote: >>> In upstream. Please fix it in upstream and qemu-kvm.git will get the >>> fix from there. >>> >> >> Given that CONFIG_GDBSTUB is always true upstream, I tend to say: >> Finally drop it upstream and keep this (or a more arch-local) workaround >> for missing ia64 gdbstub support downstream. >> > > I agree, unless > > - we want to make gdbstub support configurable (don't see any > overwhelming reason for this, but maybe others do) > - we want to merge ia64 kvm support upstream, and don't want to impose > gdbstub support (though I'd recommend properly implementing gdbstub) > > In any case, I'm okay with dropping the check upstream and applying the > local fixup. The last ia64 tcg patch I saw one or two days ago was missing gdb support, too (and may suffer from some brokenness for that reason). But I would suggest for both cases (tcg and kvm) to temporarily provide stubs/placeholders instead of keeping the central #ifdefs. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux