From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M21md-0004pC-7N
	for qemu-devel@nongnu.org; Thu, 07 May 2009 07:28:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M21mX-0004os-Ou
	for qemu-devel@nongnu.org; Thu, 07 May 2009 07:28:57 -0400
Received: from [199.232.76.173] (port=42026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M21mX-0004op-Hz
	for qemu-devel@nongnu.org; Thu, 07 May 2009 07:28:53 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47595)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M21mX-0005D1-2b
	for qemu-devel@nongnu.org; Thu, 07 May 2009 07:28:53 -0400
Message-ID: <4A02C5F1.4060205@redhat.com>
Date: Thu, 07 May 2009 14:28:49 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4A01AFE8.3020008@sgi.com>
	<706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com>
	<4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com>
	<4A02BF59.6030103@redhat.com> <4A02C277.4000402@siemens.com>
In-Reply-To: <4A02C277.4000402@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is
	disabled
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>, Jes Sorensen <jes@sgi.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>

Jan Kiszka wrote:
>> I agree, unless
>>
>> - we want to make gdbstub support configurable (don't see any
>> overwhelming reason for this, but maybe others do)
>> - we want to merge ia64 kvm support upstream, and don't want to impose
>> gdbstub support (though I'd recommend properly implementing gdbstub)
>>
>> In any case, I'm okay with dropping the check upstream and applying the
>> local fixup.
>>     
>
> The last ia64 tcg patch I saw one or two days ago was missing gdb
> support, too (and may suffer from some brokenness for that reason).

I didn't see ia64/tcg.  Did you mean s390?  That was host only IIRC.

>  But
> I would suggest for both cases (tcg and kvm) to temporarily provide
> stubs/placeholders instead of keeping the central #ifdefs.
>   

Agreed.

-- 
error compiling committee.c: too many arguments to function