From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M23CX-0000bj-2B for qemu-devel@nongnu.org; Thu, 07 May 2009 08:59:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M23CS-0000UK-9z for qemu-devel@nongnu.org; Thu, 07 May 2009 08:59:48 -0400 Received: from [199.232.76.173] (port=57472 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M23CS-0000Ts-2E for qemu-devel@nongnu.org; Thu, 07 May 2009 08:59:44 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:18735) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M23CR-0001Nd-GK for qemu-devel@nongnu.org; Thu, 07 May 2009 08:59:43 -0400 Message-ID: <4A02DB34.2080707@siemens.com> Date: Thu, 07 May 2009 14:59:32 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com> <4A02BF59.6030103@redhat.com> <4A02D539.6040705@sgi.com> In-Reply-To: <4A02D539.6040705@sgi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Anthony Liguori , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" , qemu-devel , Avi Kivity Jes Sorensen wrote: > Avi Kivity wrote: >> I agree, unless >> >> - we want to make gdbstub support configurable (don't see any >> overwhelming reason for this, but maybe others do) >> - we want to merge ia64 kvm support upstream, and don't want to impose >> gdbstub support (though I'd recommend properly implementing gdbstub) >> >> In any case, I'm okay with dropping the check upstream and applying >> the local fixup. > > Hi, > > Here's a patch that fixes the #ifndef to make it the #ifdef as it was > intended. > > I am quite fine with us trying to drop all the #ifdefs and introduce > noop wrappers for archs that do not provide the gdbstubs (ie. ia64), but > to start with we better just fix the #ifndef to make it behave like it > was originally intended. As the original change this patch (correctly) fixes broke gdbstub support in qemu-kvm for all archs + it is still a deviation from upstream, please take the chance and go for ia64 stubs. BTW, I'm planning to submit a cleanup patch for CONFIG_GDBSTUB to upstream soon. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux