From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M2TSd-0007ns-V6 for qemu-devel@nongnu.org; Fri, 08 May 2009 13:02:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M2TSX-0007lp-9B for qemu-devel@nongnu.org; Fri, 08 May 2009 13:02:09 -0400 Received: from [199.232.76.173] (port=54763 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M2TSX-0007lg-1V for qemu-devel@nongnu.org; Fri, 08 May 2009 13:02:05 -0400 Received: from gecko.sbs.de ([194.138.37.40]:19935) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M2TSU-0003hZ-Nc for qemu-devel@nongnu.org; Fri, 08 May 2009 13:02:04 -0400 Message-ID: <4A04657F.7040603@siemens.com> Date: Fri, 08 May 2009 19:01:51 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/11] Networking fixes and slirp enhancements References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net> <4A045CEE.5040603@codemonkey.ws> In-Reply-To: <4A045CEE.5040603@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Anthony Liguori wrote: > Jan Kiszka wrote: >> This series starts with four networking-related fixes and then focuses >> on a grand refactoring of the slirp user space IP stack configuration. >> >> The major contribution is that the virtual IP addresses used by slirp >> can now be (almost) freely configured. This enables sophisticated >> virtual network setups, specifically with guests that depends on >> specific addresses. >> >> Find this series also at git://git.kiszka.org/qemu.git queues/net >> >> Jan Kiszka (11): >> net: Don't deliver to disabled interfaces in qemu_sendv_packet >> net: Fix and improved ordered packet delivery >> slirp: Avoid zombie processes after fork_exec >> net: Real fix for check_params users >> net: Improve parameter error reporting >> slirp: Reorder initialization >> Introduce get_next_param_value >> slirp: Move smb, redir, tftp and bootp parameters and -net chann= el >> slirp: Rework internal configuration >> slirp: Rework external configuration interface >> slirp: Bind support for host forwarding rules >> =20 >=20 > With this series applied, I get: >=20 > CC slirp/cksum.o > In file included from /home/anthony/git/qemu/slirp/slirp.h:216, > from /home/anthony/git/qemu/slirp/cksum.c:34: > /home/anthony/git/qemu/slirp/main.h:51: error: =E2=80=98PATH_MAX=E2=80=99= undeclared > here (not in a function) > make: *** [slirp/cksum.o] Error 1 Hmpf. As I can't reproduce here: Does this add-on patch make it build? diff --git a/slirp/main.h b/slirp/main.h index 537c145..44f649a 100644 --- a/slirp/main.h +++ b/slirp/main.h @@ -9,6 +9,8 @@ #include #endif =20 +#include + #define TOWRITEMAX 512 =20 extern struct timeval tt; Jan --=20 Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux