From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M2i7W-00069z-NH
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:41:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M2i7R-00068X-QW
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:41:22 -0400
Received: from [199.232.76.173] (port=55916 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M2i7R-00068S-Hx
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:41:17 -0400
Received: from mx2.redhat.com ([66.187.237.31]:49092)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M2i7R-0000bA-FY
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:41:17 -0400
Message-ID: <4A0541A9.6060800@redhat.com>
Date: Sat, 09 May 2009 11:41:13 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1241359444-8538-1-git-send-email-avi@redhat.com>
	<1241359444-8538-2-git-send-email-avi@redhat.com>
	<4A049B0B.9030405@us.ibm.com> <4A049F96.90502@us.ibm.com>
In-Reply-To: <4A049F96.90502@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/4] kvm: Add support for querying
	supported cpu features
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

Anthony Liguori wrote:
> Anthony Liguori wrote:
>>
>> kvm_check_extension doesn't exist in upstream QEMU.  It's a good idea 
>> though so I added it in a previous commit.  However, I changed the 
>> signature to it to take a KVMState * as the first argument (which is 
>> available in env->kvm_state).  I updated this patch to pass the extra 
>> 's' parameter.
>
> Ah, you had a patch, I just didn't notice in my queue.
>

Yeah, I should have made the dependency explicit.

> Still wanted to make the KVMState change though.
>

I think the KVM_REQUIRE_EXTENSION bit didn't like it.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.