From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M2iKE-0004ir-Rf
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:54:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M2iK9-0004h8-Ov
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:54:30 -0400
Received: from [199.232.76.173] (port=34845 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M2iK9-0004h4-ID
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:54:25 -0400
Received: from mx2.redhat.com ([66.187.237.31]:50492)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M2iK9-00024p-EO
	for qemu-devel@nongnu.org; Sat, 09 May 2009 04:54:25 -0400
Message-ID: <4A0544C0.8060201@redhat.com>
Date: Sat, 09 May 2009 11:54:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <200905082053.n48Kr0rf008206@d03av04.boulder.ibm.com>
In-Reply-To: <200905082053.n48Kr0rf008206@d03av04.boulder.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy
 printf when KVM masks	CPU features
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:
> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index bdf242b..5c03e3a 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -102,7 +102,6 @@ static void kvm_trim_features(uint32_t *features, uint32_t supported,
>      for (i = 0; i < 32; ++i) {
>          mask = 1U << i;
>          if ((*features & mask) && !(supported & mask)) {
> -            printf("Processor feature %s not supported by kvm\n", names[i]);
>              *features &= ~mask;
>          }
>      }
>   

That was intentional, I didn't want to silently drop features the user 
requested as those may impact live migration or load/save (or 
application performance).

Maybe it's better to only do that if -cpu was specified on the command 
line; and exit() as well.  The user can easily pick up the missing bits 
and remove them from the requested cpu features.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.