From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M2maQ-0008Px-6z for qemu-devel@nongnu.org; Sat, 09 May 2009 09:27:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M2maI-0008NH-Ei for qemu-devel@nongnu.org; Sat, 09 May 2009 09:27:29 -0400 Received: from [199.232.76.173] (port=56629 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M2maI-0008N7-0Y for qemu-devel@nongnu.org; Sat, 09 May 2009 09:27:22 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:34766) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M2maH-0002gr-GN for qemu-devel@nongnu.org; Sat, 09 May 2009 09:27:21 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n49DN8cs030985 for ; Sat, 9 May 2009 09:23:08 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n49DRFnl152620 for ; Sat, 9 May 2009 09:27:15 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n49DREmp024786 for ; Sat, 9 May 2009 09:27:14 -0400 Message-ID: <4A0584B0.8060201@us.ibm.com> Date: Sat, 09 May 2009 08:27:12 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <200905082053.n48Kr0rf008206@d03av04.boulder.ibm.com> <4A0544C0.8060201@redhat.com> In-Reply-To: <4A0544C0.8060201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 883ecbf] Remove noisy printf when KVMmasks CPU features List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Avi Kivity wrote: > Anthony Liguori wrote: >> From: Anthony Liguori >> >> Signed-off-by: Anthony Liguori >> >> diff --git a/target-i386/helper.c b/target-i386/helper.c >> index bdf242b..5c03e3a 100644 >> --- a/target-i386/helper.c >> +++ b/target-i386/helper.c >> @@ -102,7 +102,6 @@ static void kvm_trim_features(uint32_t *features, >> uint32_t supported, >> for (i = 0; i < 32; ++i) { >> mask = 1U << i; >> if ((*features & mask) && !(supported & mask)) { >> - printf("Processor feature %s not supported by kvm\n", >> names[i]); >> *features &= ~mask; >> } >> } >> > > That was intentional, I didn't want to silently drop features the user > requested as those may impact live migration or load/save (or > application performance). Why not provide a monitor option to view the list of CPUID features that are enabled? printing to stdio is a bad idea. We print the names of pty devices to stdio and tools have to parse that today. I hope they're sufficiently robust but this isn't something we want to introduce if we don't have to. > Maybe it's better to only do that if -cpu was specified on the command > line; and exit() as well. The user can easily pick up the missing > bits and remove them from the requested cpu features. Yes, that's also a good idea. Regards, Anthony Liguori -- Regards, Anthony Liguori