From: Avi Kivity <avi@redhat.com>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Work around misreported kvm cpuid features
Date: Sun, 10 May 2009 16:17:44 +0300 [thread overview]
Message-ID: <4A06D3F8.50608@redhat.com> (raw)
In-Reply-To: <20090510131144.GA27093@miranda.arrow>
Stuart Brady wrote:
> On Sun, May 10, 2009 at 03:45:05PM +0300, Avi Kivity wrote:
>
>> These features are needed by Vista x64 to boot.
>>
>
>
>> + ret |= 1 << 12; /* MTRR */
>> + ret |= 1 << 16; /* PAT */
>> + ret |= 1 << 7; /* MCE */
>> + ret |= 1 << 14; /* MCA */
>>
>
> Just curious -- is there a reason to avoid the use of CPUID_MTRR,
> CPUID_PAT, CPUID_MCE and CPUID_MCA here?
>
Didn't notice those. Will send an updated patch.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-10 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 12:45 [Qemu-devel] [PATCH] Work around misreported kvm cpuid features Avi Kivity
2009-05-10 13:11 ` Stuart Brady
2009-05-10 13:17 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A06D3F8.50608@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sdbrady@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).