From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M38vd-00038E-NF for qemu-devel@nongnu.org; Sun, 10 May 2009 09:18:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M38vZ-00036o-CY for qemu-devel@nongnu.org; Sun, 10 May 2009 09:18:53 -0400 Received: from [199.232.76.173] (port=60691 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M38vZ-00036g-22 for qemu-devel@nongnu.org; Sun, 10 May 2009 09:18:49 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42113) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M38vY-0007iG-N1 for qemu-devel@nongnu.org; Sun, 10 May 2009 09:18:48 -0400 Message-ID: <4A06D3F8.50608@redhat.com> Date: Sun, 10 May 2009 16:17:44 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Work around misreported kvm cpuid features References: <1241959505-22031-1-git-send-email-avi@redhat.com> <20090510131144.GA27093@miranda.arrow> In-Reply-To: <20090510131144.GA27093@miranda.arrow> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady Cc: qemu-devel@nongnu.org Stuart Brady wrote: > On Sun, May 10, 2009 at 03:45:05PM +0300, Avi Kivity wrote: > >> These features are needed by Vista x64 to boot. >> > > >> + ret |= 1 << 12; /* MTRR */ >> + ret |= 1 << 16; /* PAT */ >> + ret |= 1 << 7; /* MCE */ >> + ret |= 1 << 14; /* MCA */ >> > > Just curious -- is there a reason to avoid the use of CPUID_MTRR, > CPUID_PAT, CPUID_MCE and CPUID_MCA here? > Didn't notice those. Will send an updated patch. -- error compiling committee.c: too many arguments to function