From: Gerd Hoffmann <kraxel@redhat.com>
To: vibi_sreenivasan@cms.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel][PATCH]: Fix in file qemu-sockets.c
Date: Mon, 11 May 2009 08:18:24 +0200 [thread overview]
Message-ID: <4A07C330.101@redhat.com> (raw)
In-Reply-To: <200905061527.03395.vibi_sreenivasan@cms.com>
On 05/06/09 11:57, vibi wrote:
> 1) Changed usage of malloc,free,strdup to qemu_malloc,qemu_free,qemu_strdup
> 2) Some coding style fixes (based on CODING_STYLE document)
Mixing such cleanups with actual code changes makes review very hard.
Better send whitespace/formating cleanups separate from code fixes.
cheers,
Gerd
next prev parent reply other threads:[~2009-05-11 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 9:57 [Qemu-devel][PATCH]: Fix in file qemu-sockets.c vibi
2009-05-11 6:18 ` Gerd Hoffmann [this message]
2009-05-11 7:01 ` vibisreenivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A07C330.101@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vibi_sreenivasan@cms.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).