From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M3Ort-0005RG-JX
	for qemu-devel@nongnu.org; Mon, 11 May 2009 02:20:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M3Orp-0005Qf-Rf
	for qemu-devel@nongnu.org; Mon, 11 May 2009 02:20:05 -0400
Received: from [199.232.76.173] (port=60004 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M3Orp-0005QZ-Ms
	for qemu-devel@nongnu.org; Mon, 11 May 2009 02:20:01 -0400
Received: from mx2.redhat.com ([66.187.237.31]:35135)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1M3Orp-0005MU-4k
	for qemu-devel@nongnu.org; Mon, 11 May 2009 02:20:01 -0400
Message-ID: <4A07C330.101@redhat.com>
Date: Mon, 11 May 2009 08:18:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel][PATCH]: Fix in file qemu-sockets.c
References: <200905061527.03395.vibi_sreenivasan@cms.com>
In-Reply-To: <200905061527.03395.vibi_sreenivasan@cms.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: vibi_sreenivasan@cms.com
Cc: qemu-devel@nongnu.org

On 05/06/09 11:57, vibi wrote:
> 	1) Changed usage of malloc,free,strdup to qemu_malloc,qemu_free,qemu_strdup
>   	2) Some coding style fixes (based on CODING_STYLE document)

Mixing such cleanups with actual code changes makes review very hard. 
Better send whitespace/formating cleanups separate from code fixes.

cheers,
   Gerd