qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Drop synchronous qcow_write()
Date: Wed, 13 May 2009 13:08:38 +0200	[thread overview]
Message-ID: <4A0AAA36.9040707@redhat.com> (raw)
In-Reply-To: <20090513105917.GA5349@lst.de>

Christoph Hellwig schrieb:
> Looks good to me, that strary qcow2_write irked me, too.  Do you plan
> to kill qcow_read, too?

Hm, haven't planned that because qcow_read() is used in a much more
common code path, but in theory the very same approach should work there
(and someone seems to have done this already for qcow1?).

Don't know how the emulation behaves performance wise though,
qcow_read() is used for each cluster allocation. I guess the difference
is negligible?

> Also the same patch should into qcow, too.

Right, this looks the same.

Kevin

  reply	other threads:[~2009-05-13 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 10:46 [Qemu-devel] [PATCH] qcow2: Drop synchronous qcow_write() Kevin Wolf
2009-05-13 10:59 ` Christoph Hellwig
2009-05-13 11:08   ` Kevin Wolf [this message]
2009-05-18 11:59     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0AAA36.9040707@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).