From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4CLK-00021c-Jf for qemu-devel@nongnu.org; Wed, 13 May 2009 07:09:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4CLG-0001zk-Vm for qemu-devel@nongnu.org; Wed, 13 May 2009 07:09:46 -0400 Received: from [199.232.76.173] (port=52975 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4CLG-0001zh-Pd for qemu-devel@nongnu.org; Wed, 13 May 2009 07:09:42 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35901) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M4CLG-0002lf-B8 for qemu-devel@nongnu.org; Wed, 13 May 2009 07:09:42 -0400 Message-ID: <4A0AAA36.9040707@redhat.com> Date: Wed, 13 May 2009 13:08:38 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: Drop synchronous qcow_write() References: <1242211593-16495-1-git-send-email-kwolf@redhat.com> <20090513105917.GA5349@lst.de> In-Reply-To: <20090513105917.GA5349@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig schrieb: > Looks good to me, that strary qcow2_write irked me, too. Do you plan > to kill qcow_read, too? Hm, haven't planned that because qcow_read() is used in a much more common code path, but in theory the very same approach should work there (and someone seems to have done this already for qcow1?). Don't know how the emulation behaves performance wise though, qcow_read() is used for each cluster allocation. I guess the difference is negligible? > Also the same patch should into qcow, too. Right, this looks the same. Kevin