From: Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [STABLE][PATCH 0/4] Rebase more aio dma cancellation work
Date: Thu, 14 May 2009 14:28:01 +0300 [thread overview]
Message-ID: <4A0C0041.1080809@redhat.com> (raw)
In-Reply-To: <1242298581-30587-1-git-send-email-markmc@redhat.com>
Mark McLoughlin wrote:
> Hi,
> We've a report of F11 qemu segfaulting when using read-only
> images here:
>
> https://bugzilla.redhat.com/497170
>
> Looking at the current code in stable, there is clearly some
> borkage:
>
> - No error handling in bdrv_aio_rw_vector()
>
> - No error handling in dma_bdrv_cb()/dma_bdrv_io()
>
> - VectorTranslationState is leaked by bdrv_aio_rw_vector_cb()
>
> - dma_aio_cancel() is cancelling the wrong aio
>
> The rest of Avi's aio cancellation patches actually fixes all
> these problems. Please apply to stable.
>
It's a little sad that we have to apply such a non trivial patchset to
stable, but I see no way around it. At least it has seen extensive
testing in the main branch and in qemu-kvm.git.
(Mark, you have to add your signoff if you're submitting a patch, even
if you've done no changes to it at all)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-14 11:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 22:13 [Qemu-devel] [STABLE][PATCH 0/3] Rebase aio dma cancellation work Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 1/3] Refactor aio callback allocation to use an aiocb pool Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 2/3] Convert vectored aio emulation to use a dedicated pool Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 3/3] Implement cancellation method for dma async I/O Ryan Harper
2009-04-21 21:35 ` [Qemu-devel] Re: [STABLE][PATCH 0/3] Rebase aio dma cancellation work Anthony Liguori
2009-04-22 11:03 ` Avi Kivity
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 0/4] Rebase more " Mark McLoughlin
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 1/4] Use vectored aiocb storage to store vector translation state Mark McLoughlin
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 2/4] Move block dma helpers aiocb to store dma state Mark McLoughlin
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 3/4] Fix vectored aio bounce handling immediate errors Mark McLoughlin
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 4/4] Fix DMA API when handling an immediate error from block layer Mark McLoughlin
2009-05-14 11:39 ` Mark McLoughlin
2009-05-14 11:39 ` [Qemu-devel] [STABLE][PATCH 3/4] Fix vectored aio bounce handling immediate errors Mark McLoughlin
2009-05-14 11:39 ` [Qemu-devel] [STABLE][PATCH 2/4] Move block dma helpers aiocb to store dma state Mark McLoughlin
2009-05-14 11:38 ` [Qemu-devel] [STABLE][PATCH 1/4] Use vectored aiocb storage to store vector translation state Mark McLoughlin
2009-05-14 11:28 ` Avi Kivity [this message]
2009-05-14 14:38 ` [Qemu-devel] [STABLE][PATCH 0/4] Rebase more aio dma cancellation work Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C0041.1080809@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).