From: Avi Kivity <avi@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Paul Brook <paul@codesourcery.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h
Date: Thu, 14 May 2009 15:33:21 +0300 [thread overview]
Message-ID: <4A0C0F91.1070004@redhat.com> (raw)
In-Reply-To: <4A0B2D15.5060705@mail.berlios.de>
Stefan Weil wrote:
> qemu-common.h includes most of the typical standard headers,
> so they might be removed from all QEMU source files which
> include qemu-common.h.
>
I prefer that each source file (.c or .h) explicitly include all the
headers for each of the symbols used in that file. Otherwise it is
difficult to remove headers when no longer needed.
--
error compiling committee.c: too many arguments to function
next parent reply other threads:[~2009-05-14 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905131956.n4DJu0Hg020303@d03av04.boulder.ibm.com>
[not found] ` <4A0B2D15.5060705@mail.berlios.de>
2009-05-14 12:33 ` Avi Kivity [this message]
2009-05-14 13:15 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h Anthony Liguori
2009-05-14 17:07 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C0F91.1070004@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).