* [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h
[not found] ` <4A0B2D15.5060705@mail.berlios.de>
@ 2009-05-14 12:33 ` Avi Kivity
2009-05-14 13:15 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2009-05-14 12:33 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, Paul Brook, qemu-devel
Stefan Weil wrote:
> qemu-common.h includes most of the typical standard headers,
> so they might be removed from all QEMU source files which
> include qemu-common.h.
>
I prefer that each source file (.c or .h) explicitly include all the
headers for each of the symbols used in that file. Otherwise it is
difficult to remove headers when no longer needed.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h
2009-05-14 12:33 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h Avi Kivity
@ 2009-05-14 13:15 ` Anthony Liguori
2009-05-14 17:07 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2009-05-14 13:15 UTC (permalink / raw)
To: Avi Kivity; +Cc: Paul Brook, qemu-devel
Avi Kivity wrote:
> Stefan Weil wrote:
>> qemu-common.h includes most of the typical standard headers,
>> so they might be removed from all QEMU source files which
>> include qemu-common.h.
>>
>
> I prefer that each source file (.c or .h) explicitly include all the
> headers for each of the symbols used in that file. Otherwise it is
> difficult to remove headers when no longer needed.
So do I although it can get ugly supporting multiple host
architectures. You do end up needing things like qemu-socket.h that
include the platform specific headers but that doesn't mean we need a
single header for all includes.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h
2009-05-14 13:15 ` Anthony Liguori
@ 2009-05-14 17:07 ` Stefan Weil
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2009-05-14 17:07 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Avi Kivity, Paul Brook
Anthony Liguori schrieb:
> Avi Kivity wrote:
>> Stefan Weil wrote:
>>> qemu-common.h includes most of the typical standard headers,
>>> so they might be removed from all QEMU source files which
>>> include qemu-common.h.
>>>
>>
>> I prefer that each source file (.c or .h) explicitly include all the
>> headers for each of the symbols used in that file. Otherwise it is
>> difficult to remove headers when no longer needed.
>
> So do I although it can get ugly supporting multiple host
> architectures. You do end up needing things like qemu-socket.h that
> include the platform specific headers but that doesn't mean we need a
> single header for all includes.
>
> Regards,
>
> Anthony Liguori
>
>
So this commit which removed assert.h
from the places which use it will be reverted?
Regards
Stefan Weil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-14 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200905131956.n4DJu0Hg020303@d03av04.boulder.ibm.com>
[not found] ` <4A0B2D15.5060705@mail.berlios.de>
2009-05-14 12:33 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h Avi Kivity
2009-05-14 13:15 ` Anthony Liguori
2009-05-14 17:07 ` Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).