From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h
Date: Thu, 14 May 2009 08:15:22 -0500 [thread overview]
Message-ID: <4A0C196A.5040102@codemonkey.ws> (raw)
In-Reply-To: <4A0C0F91.1070004@redhat.com>
Avi Kivity wrote:
> Stefan Weil wrote:
>> qemu-common.h includes most of the typical standard headers,
>> so they might be removed from all QEMU source files which
>> include qemu-common.h.
>>
>
> I prefer that each source file (.c or .h) explicitly include all the
> headers for each of the symbols used in that file. Otherwise it is
> difficult to remove headers when no longer needed.
So do I although it can get ugly supporting multiple host
architectures. You do end up needing things like qemu-socket.h that
include the platform specific headers but that doesn't mean we need a
single header for all includes.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-05-14 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905131956.n4DJu0Hg020303@d03av04.boulder.ibm.com>
[not found] ` <4A0B2D15.5060705@mail.berlios.de>
2009-05-14 12:33 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h Avi Kivity
2009-05-14 13:15 ` Anthony Liguori [this message]
2009-05-14 17:07 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C196A.5040102@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).