From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M4ama-0002DV-7C
	for qemu-devel@nongnu.org; Thu, 14 May 2009 09:15:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M4amV-0002D3-A9
	for qemu-devel@nongnu.org; Thu, 14 May 2009 09:15:31 -0400
Received: from [199.232.76.173] (port=57055 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M4amU-0002D0-Qo
	for qemu-devel@nongnu.org; Thu, 14 May 2009 09:15:26 -0400
Received: from qw-out-1920.google.com ([74.125.92.150]:43200)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1M4amU-00072p-IJ
	for qemu-devel@nongnu.org; Thu, 14 May 2009 09:15:26 -0400
Received: by qw-out-1920.google.com with SMTP id 4so858819qwk.4
	for <qemu-devel@nongnu.org>; Thu, 14 May 2009 06:15:25 -0700 (PDT)
Message-ID: <4A0C196A.5040102@codemonkey.ws>
Date: Thu, 14 May 2009 08:15:22 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5561650] Include assert.h
	from	qemu-common.h
References: <200905131956.n4DJu0Hg020303@d03av04.boulder.ibm.com>	<4A0B2D15.5060705@mail.berlios.de>
	<4A0C0F91.1070004@redhat.com>
In-Reply-To: <4A0C0F91.1070004@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

Avi Kivity wrote:
> Stefan Weil wrote:
>> qemu-common.h includes most of the typical standard headers,
>> so they might be removed from all QEMU source files which
>> include qemu-common.h.
>>   
>
> I prefer that each source file (.c or .h) explicitly include all the 
> headers for each of the symbols used in that file.  Otherwise it is 
> difficult to remove headers when no longer needed.

So do I although it can get ugly supporting multiple host 
architectures.  You do end up needing things like qemu-socket.h that 
include the platform specific headers but that doesn't mean we need a 
single header for all includes.

Regards,

Anthony Liguori