From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M4c5S-00037M-HG
	for qemu-devel@nongnu.org; Thu, 14 May 2009 10:39:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M4c5N-00036I-5m
	for qemu-devel@nongnu.org; Thu, 14 May 2009 10:39:05 -0400
Received: from [199.232.76.173] (port=48699 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M4c5M-000365-Qy
	for qemu-devel@nongnu.org; Thu, 14 May 2009 10:39:00 -0400
Received: from mail-gx0-f176.google.com ([209.85.217.176]:58587)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1M4c5M-000830-IL
	for qemu-devel@nongnu.org; Thu, 14 May 2009 10:39:00 -0400
Received: by gxk24 with SMTP id 24so3715809gxk.10
	for <qemu-devel@nongnu.org>; Thu, 14 May 2009 07:38:59 -0700 (PDT)
Message-ID: <4A0C2CFA.8020202@codemonkey.ws>
Date: Thu, 14 May 2009 09:38:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [STABLE][PATCH 0/4] Rebase more aio dma cancellation
	work
References: <1240265600-9469-1-git-send-email-ryanh@us.ibm.com>
	<1242298581-30587-1-git-send-email-markmc@redhat.com>
In-Reply-To: <1242298581-30587-1-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Mark McLoughlin wrote:
> Hi,
>         We've a report of F11 qemu segfaulting when using read-only
> images here:
>
>    https://bugzilla.redhat.com/497170
>
>         Looking at the current code in stable, there is clearly some
> borkage:
>
>   - No error handling in bdrv_aio_rw_vector()
>
>   - No error handling in dma_bdrv_cb()/dma_bdrv_io()
>
>   - VectorTranslationState is leaked by bdrv_aio_rw_vector_cb()
>
>   - dma_aio_cancel() is cancelling the wrong aio
>
>        The rest of Avi's aio cancellation patches actually fixes all
> these problems. Please apply to stable.
>   

Thanks Mark.

I actually cherry picked the patches directly.  This is less error prone.

Regards,

Anthony Liguori