From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M5iWF-0003AI-2m
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:43:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M5iW8-00039S-SV
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:43:17 -0400
Received: from [199.232.76.173] (port=59405 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M5iW8-00039P-P9
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:43:12 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48343)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M5iW8-00089y-90
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:43:12 -0400
Message-ID: <4A103084.2000508@redhat.com>
Date: Sun, 17 May 2009 18:43:00 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com>
	<1242574141-18488-2-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1242574141-18488-2-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@gmail.com>, Alex Graf <alex@csgraf.de>, qemu-devel@nongnu.org, Dustin Kirkland <kirkland@canonical.com>

Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  .gitmodules  |    3 +++
>  roms/gplbios |    1 +
>  2 files changed, 4 insertions(+), 0 deletions(-)
>  create mode 100644 .gitmodules
>  create mode 160000 roms/gplbios
>
> diff --git a/.gitmodules b/.gitmodules
> new file mode 100644
> index 0000000..9bdf196
> --- /dev/null
> +++ b/.gitmodules
> @@ -0,0 +1,3 @@
> +[submodule "roms/gplbios"]
> +	path = roms/gplbios
> +	url = git://repo.or.cz/gplbios/qemu.git
>   

I really prefer a relative path here, so that people can set up mirrors 
on an internal server.  Also, not everyone can access the git port.  It 
can be worked around, but it's much better to have things working out of 
the proverbial box.

Also, s/roms/firmware/ to be modern.

Having said all that, I'd rather see seabios here.  Sure, it will take 
us time to add missing features, if any, but life will be much more 
pleasant afterwards.  We should reduce our ties to the bochs bios, not 
tighten them.

-- 
error compiling committee.c: too many arguments to function