From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M5iZC-0003qK-Cn
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:46:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M5iZ7-0003ps-Ri
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:46:21 -0400
Received: from [199.232.76.173] (port=59428 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M5iZ7-0003pp-Ld
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:46:17 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48387)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M5iZ7-0000KT-7i
	for qemu-devel@nongnu.org; Sun, 17 May 2009 11:46:17 -0400
Message-ID: <4A103143.4010202@redhat.com>
Date: Sun, 17 May 2009 18:46:11 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com>
	<1242574141-18488-4-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1242574141-18488-4-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@gmail.com>, Alex Graf <alex@csgraf.de>, qemu-devel@nongnu.org, Dustin Kirkland <kirkland@canonical.com>

Anthony Liguori wrote:
> We build the roms in a sub directory of the target build directory.  This is
> anticipating a single source base (like uboot) that gets built differently for
> multiple target architectures (PPC, SH4, etc.).
>
>  
> +#  Per architecture ROMS
> +ROMS=
> +ifeq ($(TARGET_BASE_ARCH),i386)
> +ROMS+=gplbios vgabios
> +endif
> +
>   

ROMS-i386 = gplbios vgabios
ROMS = $(ROMS-$(TARGET_BASE_ARCH))

(make is not shell, it tolerates spaces around the equals sign)

Also, I think you'll need to set up the cross-compiler here for 
completeness, not that I think it will ever be used in anger.

-- 
error compiling committee.c: too many arguments to function