From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5icM-0005CE-60 for qemu-devel@nongnu.org; Sun, 17 May 2009 11:49:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5icH-0005Al-Pa for qemu-devel@nongnu.org; Sun, 17 May 2009 11:49:37 -0400 Received: from [199.232.76.173] (port=44147 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5icH-0005Ac-7R for qemu-devel@nongnu.org; Sun, 17 May 2009 11:49:33 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:56986) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5icG-0000tt-LZ for qemu-devel@nongnu.org; Sun, 17 May 2009 11:49:32 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4HFje7O011765 for ; Sun, 17 May 2009 09:45:40 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4HFnV7O150682 for ; Sun, 17 May 2009 09:49:31 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4HFnU6q000523 for ; Sun, 17 May 2009 09:49:31 -0600 Message-ID: <4A1031F4.4050401@us.ibm.com> Date: Sun, 17 May 2009 10:49:08 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com> <1242574141-18488-2-git-send-email-aliguori@us.ibm.com> <4A103084.2000508@redhat.com> In-Reply-To: <4A103084.2000508@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Glauber Costa , Alex Graf , qemu-devel@nongnu.org, Dustin Kirkland Avi Kivity wrote: > Anthony Liguori wrote: >> Signed-off-by: Anthony Liguori >> --- >> .gitmodules | 3 +++ >> roms/gplbios | 1 + >> 2 files changed, 4 insertions(+), 0 deletions(-) >> create mode 100644 .gitmodules >> create mode 160000 roms/gplbios >> >> diff --git a/.gitmodules b/.gitmodules >> new file mode 100644 >> index 0000000..9bdf196 >> --- /dev/null >> +++ b/.gitmodules >> @@ -0,0 +1,3 @@ >> +[submodule "roms/gplbios"] >> + path = roms/gplbios >> + url = git://repo.or.cz/gplbios/qemu.git >> > > I really prefer a relative path here, so that people can set up > mirrors on an internal server. Also, not everyone can access the git > port. It can be worked around, but it's much better to have things > working out of the proverbial box. Do you also include a way to automatically setup the relative path? Otherwise, it's a multi-step process for someone to fetch all of the git trees for building. We have a lot of ROMs, so this is potentially very undesirable. People can always make local changes to the .gitmodules file. > Also, s/roms/firmware/ to be modern. ROM is a little more specific in my mind. We had a long debate in IRC as to what was appropriate to include in pc-bios. One key requirement is that whatever is there has to be a ROM because of the fact that we install it in a read-only location in the file system. On embedded boards, the entire operating system stack constitutes "firmware". > Having said all that, I'd rather see seabios here. Sure, it will take > us time to add missing features, if any, but life will be much more > pleasant afterwards. We should reduce our ties to the bochs bios, not > tighten them. Actually, I want to include seabios in here too and install it by default. There's already a -bios option that can be used to change the bios file name. After some basic testing, we can decide whether we should change the default bios we use. With both installed, it's easier to have people check for bugs in one verse the other. -- Regards, Anthony Liguori