From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5kiI-0008Gv-Ii for qemu-devel@nongnu.org; Sun, 17 May 2009 14:03:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5kiE-0008G3-8j for qemu-devel@nongnu.org; Sun, 17 May 2009 14:03:54 -0400 Received: from [199.232.76.173] (port=33570 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5kiE-0008G0-2S for qemu-devel@nongnu.org; Sun, 17 May 2009 14:03:50 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38248) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M5kiD-0003dM-BB for qemu-devel@nongnu.org; Sun, 17 May 2009 14:03:49 -0400 Message-ID: <4A105181.4070700@redhat.com> Date: Sun, 17 May 2009 21:03:45 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com> <1242574141-18488-2-git-send-email-aliguori@us.ibm.com> <4A103084.2000508@redhat.com> <4A1031F4.4050401@us.ibm.com> <4A1039EB.4070906@redhat.com> <20090517175126.GA13426@shareable.org> In-Reply-To: <20090517175126.GA13426@shareable.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: Glauber Costa , Anthony Liguori , Dustin Kirkland , qemu-devel@nongnu.org, Alex Graf Jamie Lokier wrote: > Avi Kivity wrote: > >> Let's only include seabios then and reject all patches to the bochs >> bios. If that doesn't motivate people to switch, nothing will. >> > > Is there a technical reason why should people switch, other than you > want them to? Is Bochs BIOS broken in some difficult to fix way? > bochs bios is written in 16-bit assembly and a mix of 16-bit C and 32-bit gcc. It requires a special toolchain (bcc/dev86), the code is (no disrespect to its authors) quite nasty. seabios is mostly C (gcc, not dev86) and well written and maintained. No doubt you could fix the bochs bios to have these attributes, but then I'd ask if there is a technical reason why we should do that rather than switch to seabios. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.