From: Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] kvm: work around supported cpuid ioctl() brokenness
Date: Mon, 18 May 2009 01:56:20 +0300 [thread overview]
Message-ID: <4A109614.1040608@redhat.com> (raw)
In-Reply-To: <1242128454-19078-1-git-send-email-markmc@redhat.com>
Mark McLoughlin wrote:
> KVM_GET_SUPPORTED_CPUID has been known to fail to return -E2BIG
> when it runs out of entries. Detect this by always trying again
> with a bigger table if the ioctl() fills the table.
>
>
Looks good, except for
> cpuid = (struct kvm_cpuid2 *)qemu_mallocz(size);
> cpuid->nent = max;
> r = kvm_ioctl(s, KVM_GET_SUPPORTED_CPUID, cpuid);
> + if (r == 0 && cpuid->nent >= max)
> + r = -E2BIG;
>
Missing braces.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-17 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 11:40 [Qemu-devel] [PATCH] kvm: work around supported cpuid ioctl() brokenness Mark McLoughlin
2009-05-17 22:56 ` Avi Kivity [this message]
2009-05-19 17:55 ` [Qemu-devel] [PATCH v2] " Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A109614.1040608@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).