From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5phP-0004zH-MF for qemu-devel@nongnu.org; Sun, 17 May 2009 19:23:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5phM-0004wF-1N for qemu-devel@nongnu.org; Sun, 17 May 2009 19:23:19 -0400 Received: from [199.232.76.173] (port=59088 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5phL-0004w1-98 for qemu-devel@nongnu.org; Sun, 17 May 2009 19:23:15 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56512) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M5phK-0002Ni-N4 for qemu-devel@nongnu.org; Sun, 17 May 2009 19:23:15 -0400 Message-ID: <4A109C5B.2010202@redhat.com> Date: Mon, 18 May 2009 02:23:07 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com> <1242574141-18488-2-git-send-email-aliguori@us.ibm.com> <4A103084.2000508@redhat.com> <4A1031F4.4050401@us.ibm.com> <4A1039EB.4070906@redhat.com> <4A109919.2060408@codemonkey.ws> In-Reply-To: <4A109919.2060408@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , Anthony Liguori , Dustin Kirkland , qemu-devel@nongnu.org, Alex Graf Anthony Liguori wrote: >> >> I don't understand the question. The relative path is set up once >> (in .gitmodules), and that's it. > > To clone kvm-kvm.git, you have to do: > > [1] git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-kmod.git > [2] git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git > [3] cd kvm-kmod.git > [4] git submodule update --init > > For qemu.git, we'll have to repeat [2] for every ROM we include which > will at least be 6 different repositories. Contrast that to my > patchset where there's always 3 steps regardless of how many ROMs we > include. > Step 2 is unneeded. Step 4 takes care of the cloning. The relative path is relative to the repository you cloned kvm-kmod.git _from_. So, if you cloned git://git.kernel.org/pub/scm/virt/kvm-kmod.git, git will clone git://git.kernel.org/pub/scm/virt/kvm.git. But if you cloned http://git.kernel.org/pub/scm/virt/kvm-kmod.git, git will clone kvm.git using the http protocol. Similarly, if you set up a mirror somewhere, as long as kvm-kmod.git and kvm.git are under the same directory, cloning kvm-kmod.git will carry kvm.git transparently. >>> >>> We have a lot of ROMs, so this is potentially very undesirable. >>> People can always make local changes to the .gitmodules file. >> >> Not if they're a mirror. > > The normal course of usage will not involve doing a git submodule > update in QEMU. The only folks who really need to do this are > maintainers or people doing ROM development/testing. I don't think > I'm that worried about mirrors considering the target audience. > > This is different than kvm-kmod whereas all users must do git > submodule updates. That's true. I still dislike hardcoding a URL into the repository. It means that some branches become unclonable if you move the repository, at least not without manual intervention. >> >> Let's only include seabios then and reject all patches to the bochs >> bios. If that doesn't motivate people to switch, nothing will. > > I don't think it would be wise to switch the default to seabios until > after 0.11. I'm concerned that there hasn't been enough testing on > non-mainstream guests. I'd like a full release cycle worth of testing. Agreed. > > The gcc 4.1+ requirement is tough too. One of the values of switching > to seabios was moving to a more common toolchain (bcc=>gcc). Having > new tool chain restricts seems a little unfortunate. Agreed as well. I think we can work around this requirement, though. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.