From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M64Pm-0002aC-9f for qemu-devel@nongnu.org; Mon, 18 May 2009 11:06:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M64Ph-0002XN-QR for qemu-devel@nongnu.org; Mon, 18 May 2009 11:06:05 -0400 Received: from [199.232.76.173] (port=56978 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M64Pf-0002Wr-Gz for qemu-devel@nongnu.org; Mon, 18 May 2009 11:06:00 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42735) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M64Pf-0003iR-0m for qemu-devel@nongnu.org; Mon, 18 May 2009 11:05:59 -0400 Message-ID: <4A117819.5060105@redhat.com> Date: Mon, 18 May 2009 11:00:41 -0400 From: john cooper MIME-Version: 1.0 References: <4A0AFE31.70908@redhat.com> <20090518121325.GA32009@infradead.org> In-Reply-To: <20090518121325.GA32009@infradead.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: john.cooper@redhat.com, qemu-devel@nongnu.org, KVM list Christoph Hellwig wrote: > On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote: >> [Resend of earlier patch: 1/2 rebased to qemu-kvm, >> 2/2 minor tweak] > > patch 1/2 seems to be missing. It is in the kvm and qemu-devel list archives: http://www.spinics.net/lists/kvm/maillist.html http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00661.html > >> Equivalent functionality currently exists for IDE >> and SCSI, however it is not yet implemented for >> virtio. > > So why can't we re-use the existing interfaces instead of inventing a > new one? I'm unclear to what specifically you're referring -- the ioctl() used to retrieve the serial number in the guest? -john -- john.cooper@redhat.com