From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] Convert qemu-img convert to new bdrv_create
Date: Tue, 19 May 2009 09:48:14 +0200 [thread overview]
Message-ID: <4A12643E.8050408@redhat.com> (raw)
In-Reply-To: <20090518170529.GA27082@lst.de>
Christoph Hellwig schrieb:
> On Mon, May 18, 2009 at 04:42:12PM +0200, Kevin Wolf wrote:
>> This is part two of the qemu-img conversion. This really works the same as the
>> previous conversion of qemu-img create: It introduces a new -o option for the
>> generic approach and adds the old-style options to this option set.
>
> Shouldn't we kill bdrv_create2 and friends after this?
There are two references left, one in vvfat and one in block.c, both use
it for creating temporary qcow images (vvfat still uses qcow1, by the
way...)
Should be a small patch to kill them, so yes, we should do that. I will
send such a patch once this series is applied.
Kevin
prev parent reply other threads:[~2009-05-19 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 14:42 [Qemu-devel] [PATCH 0/4] Make qemu-img create options generic Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 1/4] Create qemu-option.h Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 2/4] Convert all block drivers to new bdrv_create Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 3/4] Convert qemu-img create " Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 4/4] Convert qemu-img convert " Kevin Wolf
2009-05-18 17:05 ` Christoph Hellwig
2009-05-19 7:48 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A12643E.8050408@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).