From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M6K4l-0004Dc-PO
	for qemu-devel@nongnu.org; Tue, 19 May 2009 03:49:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M6K4g-0004AR-5h
	for qemu-devel@nongnu.org; Tue, 19 May 2009 03:49:26 -0400
Received: from [199.232.76.173] (port=60760 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M6K4g-0004AF-0b
	for qemu-devel@nongnu.org; Tue, 19 May 2009 03:49:22 -0400
Received: from mx20.gnu.org ([199.232.41.8]:54412)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kwolf@redhat.com>) id 1M6K4f-0005QT-6B
	for qemu-devel@nongnu.org; Tue, 19 May 2009 03:49:21 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1M6K4e-0000GK-Bd
	for qemu-devel@nongnu.org; Tue, 19 May 2009 03:49:20 -0400
Message-ID: <4A12643E.8050408@redhat.com>
Date: Tue, 19 May 2009 09:48:14 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/4] Convert qemu-img convert to new
	bdrv_create
References: <1242657732-29043-1-git-send-email-kwolf@redhat.com>
	<1242657732-29043-5-git-send-email-kwolf@redhat.com>
	<20090518170529.GA27082@lst.de>
In-Reply-To: <20090518170529.GA27082@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Christoph Hellwig schrieb:
> On Mon, May 18, 2009 at 04:42:12PM +0200, Kevin Wolf wrote:
>> This is part two of the qemu-img conversion. This really works the same as the
>> previous conversion of qemu-img create: It introduces a new -o option for the
>> generic approach and adds the old-style options to this option set.
> 
> Shouldn't we kill bdrv_create2 and friends after this?

There are two references left, one in vvfat and one in block.c, both use
it for creating temporary qcow images (vvfat still uses qcow1, by the
way...)

Should be a small patch to kill them, so yes, we should do that. I will
send such a patch once this series is applied.

Kevin