From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6S1I-0001cR-2t for qemu-devel@nongnu.org; Tue, 19 May 2009 12:18:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6S1C-0001aS-DJ for qemu-devel@nongnu.org; Tue, 19 May 2009 12:18:22 -0400 Received: from [199.232.76.173] (port=53516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6S1C-0001aM-5l for qemu-devel@nongnu.org; Tue, 19 May 2009 12:18:18 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33089) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6S1B-0005ZY-QS for qemu-devel@nongnu.org; Tue, 19 May 2009 12:18:18 -0400 Message-ID: <4A12DBC5.3010506@redhat.com> Date: Tue, 19 May 2009 19:18:13 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH STABLE 0/3] Backport kvm cpuid feature trimming to stable References: <1242698221-32463-1-git-send-email-glommer@redhat.com> <4A123D58.1060100@redhat.com> <5d6222a80905190736m416e3512m326be22cdc5dc77d@mail.gmail.com> In-Reply-To: <5d6222a80905190736m416e3512m326be22cdc5dc77d@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel (restored cc list) Glauber Costa wrote: > On Tue, May 19, 2009 at 2:02 AM, Avi Kivity wrote: > >> Glauber Costa wrote: >> >>> subject self explanatory >>> >>> >> Right, so you have free space here to provide the motivation for the >> backport. It's a large change and it isn't immediately obvious that it's >> stable branch material. >> >> > > This does not introduce any new features. > Users expects the guest not to have any cpuid features that the host > cannot honnor. There has been multiple bug reports regarding this in > the past of Fedora users. I imagine other users have seen it too. > If it hits users then it's obviously important. Note though that Mark found some bugs there, so we need to either backport Mark's patches or look for a simpler workaround. -- error compiling committee.c: too many arguments to function